-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1540] Add update action mutation #1607
Merged
alonkeyval
merged 431 commits into
odigos-io:new-ui
from
alonkeyval:gen-1540-update-action-mutation
Oct 22, 2024
Merged
[GEN-1540] Add update action mutation #1607
alonkeyval
merged 431 commits into
odigos-io:new-ui
from
alonkeyval:gen-1540-update-action-mutation
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[GEN-1097] chore: setup redesign
[GEN-1099] chore: setup side menu
[GEN-1100] chore: setup choose source
[GEN-1503] feat: edit destination
…factor [GEN-1538] Refactor destinations types query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of action types in the
CreateAction
andUpdateAction
resolvers, as well as the addition of a new update function forAddClusterInfo
actions. The most important changes involve refactoring action type strings into constants and implementing theUpdateAddClusterInfo
function.Refactoring action types:
frontend/graph/schema.resolvers.go
: Replaced hardcoded action type strings with constants fromactionservices
for better maintainability. [1] [2]New update functionality:
frontend/graph/schema.resolvers.go
: Implemented theUpdateAction
resolver to handle updatingAddClusterInfo
actions.frontend/services/actions/addclusterinfo.go
: Added theUpdateAddClusterInfo
function to update existingAddClusterInfo
actions in Kubernetes.Constants definition:
frontend/services/actions/constants.go
: Added constants for action typesActionTypeAddClusterInfo
andActionTypeDeleteAttribute
.