feat: add profile to control if name processor is used or not #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, dotnet and java native agent both use the device id in the
service.nameresource attribute, and this is replaced by the real service name and additional k8s attributes in the node processor later on.eBPF instrumentations and OpAMP based agents injects the resource attribute directly and do not need the processor.
By default, the processor is enabled, but users that do not use the java native or dotnet may wish to disable it, and reduce load from the cluster. This PR adds a profile to do that.
This profile is temporary until we migrate dotnet and java to eBPF