Use new runtime detector for logging process events #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirdavid1
reviewed
Oct 28, 2024
tamirdavid1
approved these changes
Oct 31, 2024
RonFed
added a commit
that referenced
this pull request
Dec 4, 2024
This PR is a follow-up to #1645. Adding the new `Manager` which will eventually replace the `Director`. The new design has the following key features and improvements: 1. Use the [new runtime-detector module](https://github.com/odigos-io/runtime-detector) to trigger instrument/un-instrument events. This replaces the current approach which relies on a Pod reconciler. The pod reconciler approach main disadvantage is in scenarios of multiple containers in the same Pod and multiple processes in the same container. Changing the trigger to being process creation will allow us to guarantee we won't miss a requested instrumentation. note: the `runtime-detector` is configured to filter process events and will only pass events according to its configuration. 2. Event loop design. The current director has a lot of fixed and potential race conditions due to the concurrent nature of processes creating/exiting and Pod events from the reconciler. The new `Manager` does not have locks and uses an internal event loop. 3. Configuration updates are triggered by the `InstrumentationConfig` reconciler (same as before) - those updates will be handled in the event loop. 4. The `Factory` interface is refactored and a `Settings` option can be expanded in the future to add more initial configuration options. 5. The `Instrumentation` interface is introduced and will replace `OtelEbpfSdk`. 6. Update `go.opentelemetry.io/auto` to `v0.18.0-alpha`. This change will currently only apply for OSS Go instrumentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of using the new runtime detector module for triggering eBPF instrumentations.
Currently, it is set up by the Odiglet and only logs the events.