fix: check for all containers running instead of pod phase #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
reviewed
Oct 31, 2024
tamirdavid1
force-pushed
the
check-container-ready-started-instead-pod-phase-running
branch
from
65bfdea to
8a87f43
Compare
tamirdavid1
force-pushed
the
check-container-ready-started-instead-pod-phase-running
branch
from
fd82cdf to
d0fd4ea
Compare
RonFed
approved these changes
Nov 3, 2024
blumamir
approved these changes
Nov 3, 2024
blumamir
pushed a commit
that referenced
this pull request
Nov 15, 2024
…ler for instrumentation (#1754) Following #1666, this PR includes the following: 1. Change the predicate for ebpf instrumentation to only pass events where all the containers in a pod become ready. This will fix cases where the reconciliation was called too early and missed the relevant process. 2. Create an `AllContainersReadyPredicate` which is common to the runtime details reconciler (the predicate was added in #1666 ) and the ebpf instrumentation reconciler. 3. Create a common `DeletionPredicate` predicate - for the instrumentation reconcilation it is an OR between the containers ready predicate and the delete one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.