fix: start lang detection cm reconciler #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stale list elements bug
edeNFed
approved these changes
Nov 10, 2024
blumamir
approved these changes
Nov 10, 2024
RonFed
force-pushed
the
cm_langdetection_reconcile_fix
branch
from
5911c41
to
d9dd276
Compare
blumamir
pushed a commit
that referenced
this pull request
Nov 10, 2024
Following #1722, use the `ConfigMapDataChangedPredicate` in conjunction with `OdigosConfigMapPredicate` to only handle update events from our config map in autoscaler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 main issues in the config map reconciler in the lang detection package inside the instrumentor.
The only goal of this reconciler is to trigger runtime detection in case of a change in the ignored containers field in Odigos config.
Adding a util predicate for the config map data change one.
note: the reconcile logic can in the OdigosConfig reconciler can be improved by iterating over the instrumentationconfigs and marking them to perform runtime detection - instead of iterating over the workloads which is what is done today. This is left out of this PR since the runtime detection signaling is constantly being refactored, and for making this PR smaller and easier to review.