Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubernetes version 1.20.15 #1751

Merged
merged 11 commits into from
Nov 15, 2024
Merged

Support Kubernetes version 1.20.15 #1751

merged 11 commits into from
Nov 15, 2024

Conversation

david336362
Copy link
Contributor

No description provided.

Copy link
Contributor

@RonFed RonFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.
In addition, I think we can move some of the functions to k8sutils and some of the versions which are used for feature checking to the consts.go file in k8sutils.

autoscaler/main.go Outdated Show resolved Hide resolved
autoscaler/controllers/datacollection/daemonset.go Outdated Show resolved Hide resolved
autoscaler/controllers/datacollection/daemonset.go Outdated Show resolved Hide resolved
cli/pkg/kube/client.go Outdated Show resolved Hide resolved
cli/pkg/kube/client.go Outdated Show resolved Hide resolved
autoscaler/controllers/datacollection/daemonset.go Outdated Show resolved Hide resolved
@blumamir blumamir changed the title Support Kubernetes version 1.20.25 Support Kubernetes version 1.20.15 Nov 15, 2024
autoscaler/migration.go Outdated Show resolved Hide resolved
}
} else {
// Create a non-caching client for versions < 1.23
migrationClient, err = client.New(cfg, client.Options{Scheme: scheme})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes this client non caching?

cli/cmd/install.go Outdated Show resolved Hide resolved
cli/go.mod Outdated Show resolved Hide resolved
@blumamir blumamir merged commit 56a0a48 into main Nov 15, 2024
30 of 31 checks passed
@blumamir blumamir deleted the support_kube_1_20_15 branch November 15, 2024 14:35
Copy link

2 similar comments
Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants