-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kubernetes version 1.20.15 #1751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments.
In addition, I think we can move some of the functions to k8sutils
and some of the versions which are used for feature checking to the consts.go
file in k8sutils
.
autoscaler/main.go
Outdated
} | ||
} else { | ||
// Create a non-caching client for versions < 1.23 | ||
migrationClient, err = client.New(cfg, client.Options{Scheme: scheme}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes this client non caching?
bb170f5
to
c78fa30
Compare
c78fa30
to
902a5f8
Compare
No description provided.