Add PersistentPreRun to the root CLI cmd to set the kube client and cluster details once for all commands #1759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
PersistentPreRun
which will be inherited by all sub-commands of the root command.Perform a client initialzation in that function and set the cluster kind and k8s version as well - so they can be used by all commands. Both the kube client and the cluster details are set on the command context and can be used by all the commands.
The helper function from k8sutils
GetKubernetesVersion
can't be used outside of the cluster by the CLI since it as using a rest client which states:Hence, removing the use of this function from the CLI, and using the k8s version which was calculated in the
PersistentPreRun
function.Before this change
odigos upgrade
resulted in errors such as: