[GEN-1702] Add odigos UI beta flag #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[GEN-1340] chore: connect form validation
[GEN-1359] chore: merge upstream
[GEN-1341] chore: delete old setup files
[GEN-1136] chore: overview header
[GEN-1361] feat: get destination - gql
[GEN-1400] feat: get actual sources
[GEN-1402] chore: get actual actions
[GEN-1043] chore: insert destinations and action to cp and create resolvers
[GEN-1405] chore: change api to new schema and delete unused files
[GEN-1406] chore: pull main
…n-1702-odigos-ui-beta-flag
blumamir
approved these changes
Nov 17, 2024
frontend/main.go
Outdated
| @@ -215,6 +271,8 @@ func httpFileServerWith404(fs http.FileSystem) http.Handler { | |||
| }) | |||
| } | |||
|
|
|||
| ////dep server | |||
frontend/main.go
Outdated
| @@ -204,7 +260,7 @@ func startHTTPServer(flags *Flags, odigosMetrics *collectormetrics.OdigosMetrics | |||
| return r, nil | |||
| } | |||
|
|
|||
| func httpFileServerWith404(fs http.FileSystem) http.Handler { | |||
| func httpFileDepServerWith404(fs http.FileSystem) http.Handler { | |||
blumamir
reviewed
Nov 17, 2024
cli/cmd/ui.go
Outdated
| func init() { | ||
| rootCmd.AddCommand(uiCmd) | ||
| uiCmd.Flags().Int("port", defaultPort, "port to listen on") | ||
| uiCmd.Flags().Int("port", defaultPort, "Port to listen on 3000") |
There was a problem hiding this comment.
Suggested change
| uiCmd.Flags().Int("port", defaultPort, "Port to listen on 3000") | |
| uiCmd.Flags().Int("port", defaultPort, "Port to listen on") |
blumamir
reviewed
Nov 17, 2024
cli/cmd/ui.go
Outdated
| uiCmd.Flags().String("address", "localhost", "Address to listen on") | ||
| uiCmd.Flags().Bool("beta", false, "this flag is used to start the beta version of the UI") |
There was a problem hiding this comment.
Suggested change
| uiCmd.Flags().Bool("beta", false, "this flag is used to start the beta version of the UI") | |
| uiCmd.Flags().Bool("beta", false, "use new experimental ui") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
cli/cmd/ui.goandfrontenddirectories, focusing on adding support for a beta UI, enhancing instrumentation labeling, and refactoring the code to use the Gin framework for HTTP handling.Support for Beta UI:
betaDefaultPortand modified theuiCmdto include abetaflag that allows port-forwarding the beta UI pod on port 3001. (cli/cmd/ui.go) [1] [2] [3]frontend/main.goto support running a separate server for the beta UI, including embedding the beta UI files and handling GraphQL requests. (frontend/main.go) [1] [2] [3] [4] [5] [6] [7]Instrumentation Labeling Enhancements:
WorkloadLabeledtoAppInstrumentationLabeledand introduced new fieldsNsInstrumentationLabeledandInstrumentationEffectiveto track instrumentation status more accurately. (frontend/endpoints/applications.go) [1] [2] [3] [4] [5]frontend/endpoints/applications.go)Refactoring to Use Gin Framework:
frontend/endpoints/config.go,frontend/endpoints/destinations.go,frontend/endpoints/namespaces.go,frontend/endpoints/sources.go) [1] [2] [3] [4] [5]Dockerfile Update:
frontend/Dockerfile)These changes collectively improve the functionality and maintainability of the code, providing better support for a beta UI and enhancing the instrumentation labeling mechanism.