Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1683]: warning modal - warn again #1773

Merged
merged 133 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
133 commits
Select commit Hold shift + click to select a range
c25c631
Merge pull request #1 from odigos-io/main
BenElferink Oct 20, 2024
12046ba
Refactor old ui to new product design (#1605)
alonkeyval Oct 21, 2024
6037f4c
Merge remote-tracking branch 'odigos/new-ui' into gen-1511-new-ui
BenElferink Oct 21, 2024
62934de
[GEN-1539] Refactor action api to gql (#1606)
alonkeyval Oct 22, 2024
d456363
[GEN-1540] Add update action mutation (#1607)
alonkeyval Oct 22, 2024
02682f9
Merge branch 'new-ui' of https://github.com/odigos-io/odigos into gen…
BenElferink Oct 22, 2024
522e782
feat(frontend): added actions form, and fixed bugs: empty inputs, sea…
BenElferink Oct 22, 2024
f435deb
[GEN-1541] Add delete action mutation (#1609)
alonkeyval Oct 22, 2024
9dbdc21
Lint rules (#1610)
alonkeyval Oct 22, 2024
a55f35b
fix: KeyValueInputsList would not always call onChange
BenElferink Oct 22, 2024
619bb6d
feat: custom fields with state management
BenElferink Oct 22, 2024
389fc46
fix: semicolon
BenElferink Oct 22, 2024
2487549
fix: docs link
BenElferink Oct 22, 2024
9e5224b
fix: frament & imports
BenElferink Oct 22, 2024
e4a8350
fix: MONITORING_OPTIONS from global consts
BenElferink Oct 22, 2024
a908130
fix: use const, not string
BenElferink Oct 22, 2024
38e862f
Merge pull request #2 from BenElferink/gen-1515-dynamic-action-form
BenElferink Oct 22, 2024
31f1db3
fix: dynamic signals for actions
BenElferink Oct 22, 2024
bc3bad3
fix: drawer & modal widths
BenElferink Oct 22, 2024
f1ac07b
[GEN-1546] Add delete attr new api (#1612)
alonkeyval Oct 22, 2024
254427a
[GEN-1546] Add pii masking new api (#1613)
alonkeyval Oct 22, 2024
c769731
[GEN-1513]: actions modal form (#1608)
BenElferink Oct 22, 2024
89a6594
fix: stringify for graphql
BenElferink Oct 22, 2024
9d260f4
Merge remote-tracking branch 'odigos/new-ui' into gen-1515-fix-string…
BenElferink Oct 22, 2024
19eb1fe
[GEN-1515]: fix stringify for graphql (#1615)
BenElferink Oct 27, 2024
446c37a
Merge branch 'main' into new-ui
BenElferink Oct 27, 2024
f97a5a1
Merge pull request #4 from odigos-io/new-ui
BenElferink Oct 27, 2024
944480f
[GEN-1547] Add error sampler api (#1629)
alonkeyval Oct 27, 2024
2637c1e
[GEN-1555] Add new latency sampler api (#1630)
alonkeyval Oct 27, 2024
4cedea9
[GEN-1557] Add prod sampler new api (#1631)
alonkeyval Oct 27, 2024
40f2215
[GEN-1559] Add new gql api for rename attr action (#1634)
alonkeyval Oct 27, 2024
2d4b1bb
[GEN-1517]: actions add via gql (#1635)
BenElferink Oct 27, 2024
afa1268
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 27, 2024
eff6d90
[GEN-1529]: latency sampler (#1644)
BenElferink Oct 28, 2024
536f32f
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 28, 2024
1ea39de
[GEN-1521]: update action - AddClusterInfo (#1646)
BenElferink Oct 28, 2024
fa352be
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 28, 2024
f3c1a26
[GEN-1579]: button outline (#1647)
BenElferink Oct 28, 2024
3bb2338
[GEN-1580]: useKeyDown hook fixed (#1648)
BenElferink Oct 28, 2024
a4f03d8
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 28, 2024
2a83b84
[GEN-1591]: make "add action" in overview functional (#1650)
BenElferink Oct 29, 2024
b3fa682
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 29, 2024
9ac0d13
[GEN-1583]: fix validations for "add actions" custom fields (#1651)
BenElferink Oct 29, 2024
f0a397f
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 29, 2024
33cb867
[GEN-1521]: update actions (#1652)
BenElferink Oct 29, 2024
2c13a75
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 29, 2024
d42c32b
[GEN-1593]: upgraded "status" component (#1655)
BenElferink Oct 29, 2024
3ab5c0c
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 29, 2024
c15a6ba
[GEN-1574]: delete actions (#1657)
BenElferink Oct 30, 2024
977c57b
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 30, 2024
fa609c3
[GEN-1592] Add instrumentation rules to gql (#1659)
alonkeyval Oct 30, 2024
78eda6e
[GEN-1582]: UI tweaks (#1658)
BenElferink Oct 30, 2024
6a91aba
[GEN-1603]: add rules column to overview (#1661)
BenElferink Oct 30, 2024
d95b6fe
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 30, 2024
fa5c457
fix: autocompleted notification type (#1664)
BenElferink Oct 31, 2024
cde9bdd
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 31, 2024
93bbe30
[GEN-1604]: create & get rules (#1665)
BenElferink Oct 31, 2024
7ca44f7
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Oct 31, 2024
c270e78
[GEN-1616] Add delete destination to gql (#1669)
alonkeyval Nov 3, 2024
9358337
[GEN-1601]: refetch after create/update destination (#1668)
BenElferink Nov 3, 2024
29d2e0d
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 3, 2024
08eacfe
[GEN-1581]: lists auto-focus & disable delete (#1670)
BenElferink Nov 3, 2024
240730f
[GEN-1613]: delete destination (#1672)
BenElferink Nov 3, 2024
5647431
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 3, 2024
9748362
[GEN-1620] Add metrics to gql (#1675)
alonkeyval Nov 3, 2024
8d22beb
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 3, 2024
a4a5d34
[GEN-1584]: fix close modal & animations (#1676)
BenElferink Nov 3, 2024
d933798
[GEN-1536]: scramble secret values (#1677)
BenElferink Nov 3, 2024
e53746d
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 3, 2024
2c9c79b
[GEN-1621]: add cancel modal & breakdown overview-drawer files (#1682)
BenElferink Nov 4, 2024
0dab5bd
[GEN-1626]: add mockup for overview filters (#1683)
BenElferink Nov 4, 2024
6fa1955
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 4, 2024
702e71a
[GEN-1641]: added UI for metrics (#1688)
BenElferink Nov 5, 2024
a6b6ec2
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 5, 2024
577ef58
[GEN-1646] Add destination condition and type (#1692)
alonkeyval Nov 5, 2024
746f560
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 5, 2024
0c39a29
[GEN-1642]: get metrics from API (with mockup for dev mode) (#1693)
BenElferink Nov 5, 2024
5c55719
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 5, 2024
a816fda
[GEN-1624]: refactor existing components in preparation for notificat…
BenElferink Nov 6, 2024
c790156
[GEN-1670]: kill redux, use new toasts (#1699)
BenElferink Nov 6, 2024
d9292ff
[GEN-1671]: toast animations + enriched messages (#1701)
BenElferink Nov 6, 2024
834e5ed
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 6, 2024
e15ea9a
[GEN-1672]: add logic for "go to details" button of toast notificatio…
BenElferink Nov 7, 2024
8f1cd3e
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 7, 2024
9f25eb4
[GEN-1668]: add handling for "dirty forms" (#1704)
BenElferink Nov 7, 2024
f4435c0
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 7, 2024
f596073
[GEN-1665]: formatting with prettier instead of eslint (#1705)
BenElferink Nov 10, 2024
b3b5007
[GEN-1629]: boolean store (isPolling) (#1706)
BenElferink Nov 10, 2024
1cd0a4b
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 10, 2024
0bbd34b
[GEN-1679]: added useSourceCRUD hook (#1720)
BenElferink Nov 10, 2024
eec5074
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 10, 2024
d9e8582
[GEN-1669] delete unused files (#1721)
alonkeyval Nov 10, 2024
c94d982
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 10, 2024
f32923b
[GEN-1680]: added new "toggle buttons" component (#1723)
BenElferink Nov 10, 2024
8771192
[GEN-1691] load styled on server (#1725)
alonkeyval Nov 10, 2024
5e3bb02
[GEN-1694]: search overview entities (#1731)
BenElferink Nov 11, 2024
fed3d84
Merge branch 'new-ui' of https://github.com/odigos-io/odigos
BenElferink Nov 11, 2024
b24e7c1
feat: UI tweaks in prep for overview filters
BenElferink Nov 11, 2024
5e078a4
feat: add filter action buttons
BenElferink Nov 11, 2024
5cf7fdd
feat: filter overview by namespace
BenElferink Nov 11, 2024
5cdb31e
feat: filter overview by "kind"
BenElferink Nov 11, 2024
3a371f7
feat: filter over by metrics
BenElferink Nov 11, 2024
d0748e9
feat: add logic for dropdown mutli-select
BenElferink Nov 11, 2024
d7ec9fb
fix: temporary labels for multi select
BenElferink Nov 11, 2024
b42215d
fix: dropdown smaller components
BenElferink Nov 11, 2024
80bb335
feat: multi-labels with remove buttons
BenElferink Nov 11, 2024
d10a8fd
fix: minor edits
BenElferink Nov 11, 2024
ad8323c
fix: filters is now a container
BenElferink Nov 11, 2024
29a9b27
perf: re-use styled components
BenElferink Nov 11, 2024
704e86d
fix: button alignment
BenElferink Nov 11, 2024
51bf1d3
fix: smaller components
BenElferink Nov 11, 2024
5130970
fix: continued cleanup
BenElferink Nov 11, 2024
9e3b772
feat: prepare component for error messages dropdown
BenElferink Nov 11, 2024
c868eab
feat: filter overview by error messages
BenElferink Nov 11, 2024
5f88f86
fix: toggle & dropdown
BenElferink Nov 12, 2024
52a7065
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos …
BenElferink Nov 12, 2024
d1674a5
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos …
BenElferink Nov 12, 2024
2abe0e4
fix: duplicates
BenElferink Nov 12, 2024
4e19e69
fix: dropdown
BenElferink Nov 12, 2024
6d2af50
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos …
BenElferink Nov 12, 2024
89ab764
Merge pull request #5 from BenElferink/gen-1695
BenElferink Nov 12, 2024
05f0b0d
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos
BenElferink Nov 14, 2024
e24f361
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos
BenElferink Nov 17, 2024
9b886ba
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos
BenElferink Nov 17, 2024
7776a8f
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos
BenElferink Nov 17, 2024
b6be431
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos
BenElferink Nov 17, 2024
baaa603
fix: transition would mount before it should
BenElferink Nov 18, 2024
879dfdb
fix: divider color
BenElferink Nov 18, 2024
b219264
feat: warning modal - warn again
BenElferink Nov 18, 2024
a4cc8d7
fix: drawer size
BenElferink Nov 18, 2024
4b1232a
fix: modal size
BenElferink Nov 18, 2024
d9f8a10
fix: code review
BenElferink Nov 18, 2024
9349817
fix: rename prop
BenElferink Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions frontend/webapp/components/modals/delete-warning/index.tsx
Original file line number Diff line number Diff line change
@@ -1,21 +1,28 @@
import React from 'react';
import { WarningModal } from '@/reuseable-components';
import { NotificationType } from '@/types';

interface Props {
isOpen: boolean;
noOverlay?: boolean;
name?: string;
note?: {
type: NotificationType;
title: string;
message: string;
};
onApprove: () => void;
onDeny: () => void;
}

const DeleteWarning: React.FC<Props> = ({ isOpen, noOverlay, name, onApprove, onDeny }) => {
const DeleteWarning: React.FC<Props> = ({ isOpen, noOverlay, name, note, onApprove, onDeny }) => {
return (
<WarningModal
isOpen={isOpen}
noOverlay={noOverlay}
title={`Delete${name ? ` ${name}` : ''}`}
description='Are you sure you want to delete this?'
description='Are you sure you want to delete?'
note={note}
approveButton={{
text: 'Delete',
variant: 'danger',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const Container = styled.div`
`;

const MultiSourceControl = () => {
const { deleteSources } = useSourceCRUD();
const { sources, deleteSources } = useSourceCRUD();
const { configuredSources, setConfiguredSources } = useAppStore((state) => state);
const [isWarnModalOpen, setIsWarnModalOpen] = useState(false);

Expand Down Expand Up @@ -70,7 +70,21 @@ const MultiSourceControl = () => {
</Button>
</Transition>

<DeleteWarning isOpen={isWarnModalOpen} name={`${totalSelected} sources`} onApprove={onDelete} onDeny={() => setIsWarnModalOpen(false)} />
<DeleteWarning
isOpen={isWarnModalOpen}
name={`${totalSelected} sources`}
note={
totalSelected === sources.length
? {
type: 'warning',
title: "You're about to delete the last source",
message: 'This will break your pipeline!',
}
: undefined
}
onApprove={onDelete}
onDeny={() => setIsWarnModalOpen(false)}
/>
</>
);
};
Expand Down
33 changes: 31 additions & 2 deletions frontend/webapp/containers/main/overview/overview-drawer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@ import DrawerFooter from './drawer-footer';
import { Drawer } from '@/reuseable-components';
import DrawerHeader, { DrawerHeaderRef } from './drawer-header';
import { CancelWarning, DeleteWarning } from '@/components/modals';
import { OVERVIEW_ENTITY_TYPES } from '@/types';
import { useDestinationCRUD, useSourceCRUD } from '@/hooks';

const DRAWER_WIDTH = '640px';
// + 64 because of padding
const DRAWER_WIDTH = `${640 + 64}px`;

interface Props {
title: string;
Expand All @@ -32,6 +35,8 @@ const ContentArea = styled.div`
`;

const OverviewDrawer: React.FC<Props & PropsWithChildren> = ({ children, title, imageUri, isEdit, isFormDirty, onEdit, onSave, onDelete, onCancel }) => {
const { sources } = useSourceCRUD();
const { destinations } = useDestinationCRUD();
const selectedItem = useDrawerStore(({ selectedItem }) => selectedItem);
const setSelectedItem = useDrawerStore(({ setSelectedItem }) => setSelectedItem);

Expand Down Expand Up @@ -80,6 +85,15 @@ const OverviewDrawer: React.FC<Props & PropsWithChildren> = ({ children, title,
onSave(titleRef.current?.getTitle() || '');
};

const isLastItem = () => {
let isLast = false;

if (selectedItem?.type === OVERVIEW_ENTITY_TYPES.SOURCE) isLast = sources.length === 1;
if (selectedItem?.type === OVERVIEW_ENTITY_TYPES.DESTINATION) isLast = destinations.length === 1;

return isLast;
};

return (
<>
<Drawer isOpen onClose={isEdit ? clickCancel : closeDrawer} width={DRAWER_WIDTH} closeOnEscape={!isDeleteModalOpen && !isCancelModalOpen}>
Expand All @@ -90,7 +104,22 @@ const OverviewDrawer: React.FC<Props & PropsWithChildren> = ({ children, title,
</DrawerContent>
</Drawer>

<DeleteWarning isOpen={isDeleteModalOpen} noOverlay name={`${selectedItem?.type}${title ? ` (${title})` : ''}`} onApprove={handleDelete} onDeny={closeWarningModals} />
<DeleteWarning
isOpen={isDeleteModalOpen}
noOverlay
name={`${selectedItem?.type}${title ? ` (${title})` : ''}`}
note={
isLastItem()
? {
type: 'warning',
title: `You're about to delete the last ${selectedItem?.type}`,
message: 'This will break your pipeline!',
}
: undefined
}
onApprove={handleDelete}
onDeny={closeWarningModals}
/>
<CancelWarning isOpen={isCancelModalOpen} noOverlay name='edit mode' onApprove={handleCancel} onDeny={closeWarningModals} />
</>
);
Expand Down
3 changes: 3 additions & 0 deletions frontend/webapp/public/icons/notification/warning-icon2.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion frontend/webapp/reuseable-components/divider/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const StyledDivider = styled.div<{
width: ${({ $orientation, $thickness, $length }) => ($orientation === 'vertical' ? `${$thickness}px` : $length || '100%')};
height: ${({ $orientation, $thickness, $length }) => ($orientation === 'horizontal' ? `${$thickness}px` : $length || '100%')};
margin: ${({ $orientation, $margin }) => $margin || ($orientation === 'horizontal' ? '8px 0' : '0 8px')};
background-color: ${({ color, theme }) => color || theme.colors.border};
background-color: ${({ $color, theme }) => $color || theme.colors.border};
`;

const Divider: React.FC<Props> = ({ orientation = 'horizontal', thickness = 1, length, color, margin }) => {
Expand Down
41 changes: 27 additions & 14 deletions frontend/webapp/reuseable-components/modal/warning-modal/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import React from 'react';
import styled from 'styled-components';
import { Button, ButtonProps, Modal, Text } from '@/reuseable-components';
import { useKeyDown } from '@/hooks';
import styled from 'styled-components';
import type { NotificationType } from '@/types';
import { Button, ButtonProps, Modal, NotificationNote, Text } from '@/reuseable-components';

interface ButtonParams {
text: string;
Expand All @@ -14,6 +15,11 @@ interface Props {
noOverlay?: boolean;
title: string;
description: string;
note?: {
type: NotificationType;
title: string;
message: string;
};
approveButton: ButtonParams;
denyButton: ButtonParams;
}
Expand Down Expand Up @@ -46,32 +52,39 @@ const Footer = styled.div`
`;

const FooterButton = styled(Button)`
width: 224px;
width: 250px;
`;

export const WarningModal: React.FC<Props> = ({ isOpen, noOverlay, title = '', description = '', approveButton, denyButton }) => {
useKeyDown(
{
key: 'Enter',
active: isOpen,
},
() => approveButton.onClick()
);
const NoteWrapper = styled.div`
margin-bottom: 12px;
`;

export const WarningModal: React.FC<Props> = ({ isOpen, noOverlay, title = '', description = '', note, approveButton, denyButton }) => {
useKeyDown({ key: 'Enter', active: isOpen }, () => approveButton.onClick());

const onApprove = () => approveButton.onClick();
const onDeny = () => denyButton.onClick();

return (
<Modal isOpen={isOpen} noOverlay={noOverlay} onClose={denyButton.onClick}>
<Modal isOpen={isOpen} noOverlay={noOverlay} onClose={onDeny}>
<Container>
<Title>{title}</Title>

<Content>
<Description>{description}</Description>
</Content>

{!!note && (
<NoteWrapper>
<NotificationNote type={note.type} title={note.title} message={note.message} />
</NoteWrapper>
)}

<Footer>
<FooterButton variant={approveButton.variant || 'primary'} onClick={approveButton.onClick}>
<FooterButton variant={approveButton.variant || 'primary'} onClick={onApprove}>
{approveButton.text}
</FooterButton>
<FooterButton variant={denyButton.variant || 'secondary'} onClick={denyButton.onClick}>
<FooterButton variant={denyButton.variant || 'secondary'} onClick={onDeny}>
{denyButton.text}
</FooterButton>
</Footer>
Expand Down
4 changes: 3 additions & 1 deletion frontend/webapp/reuseable-components/transition/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { PropsWithChildren, useEffect, useMemo, useState } from 'react';
import React, { PropsWithChildren, useEffect, useState } from 'react';
import styled from 'styled-components';
import type { IStyledComponentBase, Keyframes, Substitute } from 'styled-components/dist/types';

Expand Down Expand Up @@ -26,6 +26,8 @@ export const Transition: React.FC<PropsWithChildren<Props>> = ({ container: Cont
if (enter) setIsEntered(true);
}, [enter]);

if (!enter && !isEntered) return null;

return (
<AnimatedContainer $isEntering={enter} $isLeaving={isEntered && !enter} $animateIn={animateIn} $animateOut={animateOut}>
{children}
Expand Down
2 changes: 1 addition & 1 deletion frontend/webapp/styles/styled.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const Overlay = styled.div`
export const ModalBody = styled.div`
width: 640px;
height: calc(100vh - 300px);
margin: 0 15vw;
margin: 0 7vw;
padding-top: 64px;
overflow-y: scroll;
`;
2 changes: 1 addition & 1 deletion frontend/webapp/utils/functions/icons.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const getStatusIcon = (status?: NotificationType) => {
case 'error':
return '/icons/notification/error-icon2.svg';
case 'warning':
return '/icons/notification/warning-icon.svg';
return '/icons/notification/warning-icon2.svg';
case 'info':
return '/icons/common/info.svg';
default:
Expand Down
Loading