Refactor old UI onboarding issue #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer Task 149 sources container
…play-source-manage-list
…urces-card Task 107 overview sources card
…rce-manage-list Task 142 display source manage list
…rce-btn Task 143 add new source btn
…sources-connection Task 145 handle new sources connection
Get rid of these warnings in odigos CI: > build-odigos-imagesThe following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default
Another small change, should have been in odigos-io#1698 Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to the codebase, focusing on updating dependencies, modifying configuration files, and enhancing the autoscaler controllers. The most important changes include updating the GitHub Actions workflow, modifying the autoscaler controllers to use a new configuration structure, and adding tooltips to the ClickHouse destination configuration.
Dependency Updates:
actions/upload-artifact@v4andactions/download-artifact@v4instead of version 3. (.github/workflows/e2e.yaml) [1] [2] [3]Autoscaler Controllers:
ControllerConfigstructure to replaceMetricsServerEnabledwithK8sVersion. (autoscaler/controllers/controller_config/controller_config.go)Syncfunction ingateway/root.goto use the newControllerConfigstructure and handle different Kubernetes versions for HorizontalPodAutoscaler. (autoscaler/controllers/gateway/root.go) [1] [2] [3] [4]isMetricsServerInstalledfunction frommain.goand updated the main function to use the newControllerConfig. (autoscaler/main.go) [1] [2]Configuration Files:
destinations/data/clickhouse.yaml) [1] [2]Codebase Simplification:
autoscaler/controllers/gateway/hpa.go,autoscaler/main.go) [1] [2] [3]