Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set max_recv_msg_size_mib to value in correct units #1826

Merged
merged 1 commit into from
Nov 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/config/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func getBasicConfig(memoryLimiterConfig GenericMap) (*Config, []string) {
"protocols": GenericMap{
"grpc": GenericMap{
// setting it to a large value to avoid dropping batches.
"max_recv_msg_size_mib": 128 * 1024 * 1024,
"max_recv_msg_size_mib": 128,
"endpoint": "0.0.0.0:4317",
},
// Node collectors send in gRPC, so this is probably not needed
Expand Down
2 changes: 1 addition & 1 deletion common/config/testdata/debugexporter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ receivers:
protocols:
grpc:
endpoint: 0.0.0.0:4317
max_recv_msg_size_mib: 134217728
max_recv_msg_size_mib: 128
http:
endpoint: 0.0.0.0:4318
exporters:
Expand Down
2 changes: 1 addition & 1 deletion common/config/testdata/minimal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ receivers:
protocols:
grpc:
endpoint: 0.0.0.0:4317
max_recv_msg_size_mib: 134217728
max_recv_msg_size_mib: 128
http:
endpoint: 0.0.0.0:4318
exporters: {}
Expand Down
Loading