-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Last9 as destination #1828
Add Last9 as destination #1828
Conversation
d4ced2d
to
2c62394
Compare
2c62394
to
a963574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @prathamesh-sonpatki
This looks great. added few small nits.
I tried to open an account in last9 to test the integration, but seems the OpenTelemetry receiver should be enabled on your side:
The OpenTelemetry endpoint is not enabled. Please request to proceed.
Request to enable OpenTelemetry endpoint ↗
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Thanks, @blumamir. I have taken the review comments. You will see the OpenTelemetry endpoint available in your Last9 account 👍🏽 Let me know if any other change is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @prathamesh-sonpatki
Tried the integration locally from your branch. needed to apply few fixes to make it work (added as PR comments).
After those fixes, I can see data in your system.
Question: the api endpoint: https://otlp.last9.io:443
- will it always be this constant value for all users? if so, perhaps we can remove it from the config or make it optional to reduce friction and required configuration?
2 issues I detected in Last9
while testing:
- on boarding screen, if I click the copy button for
Auth Header
it copies the value ofpassword
which was a bit difficult to figure out. - when searching traces in grafana with the
tempo
data source, every trace I click results in this message: "failed to get trace with id: 2f103f9e25b3b8ab1c7d66bd2325bbc8 Status: 404 Not Found Body: {"error":"trace not found"}"
Thanks again for adding this integration
@blumamir Thanks! I have taken care of the feedback :)
Thanks! |
@prathamesh-sonpatki looks great. Few more issues I spotted in last 9 while testing:
|
Add Last9 as a destination.
Last9 supports all telemetry signals Logs, Metrics and Traces