UI bugs party (high priority tasks) #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1853) Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com> Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
alonkeyval
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the frontend web application, primarily focusing on improving the user interface and refactoring the codebase. The most important changes include adding new permissions, updating file handling logic, and refactoring components related to destination management.
Permissions and UI Enhancements:
cli/cmd/resources/ui.go: Added permissions for listing services.frontend/main.go: Updated the file server logic to serve.htmlfiles if the requested file is not found, and redirect to the root path if neither the file nor its.htmlversion is found.Component Refactoring:
frontend/webapp/app/(setup)/choose-destination/page.tsx: ReplacedChooseDestinationContainerwithAddDestinationContainer.add-destination-button,edit-destination-form, andmonitors-tap-list. [1] [2] [3]Styling Updates:
frontend/webapp/app/globals.css: Added custom scrollbar styling.frontend/webapp/app/layout.tsx: Adjusted layout styles for better positioning and appearance.Component Renaming and Refactoring:
action-drawer-containertoaction-drawer, updating related imports and logic. [1] [2] [3]action-form-bodyfor better readability and maintainability. [1] [2] [3]