-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1730]: add "describe odigos" to UI #1988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to describe Odigos and includes various changes to integrate this feature into the application. The most important changes include the addition of a new
DescribeOdigos
component, updates to existing components to incorporate this new feature, and the creation of a GraphQL query and hook for fetching Odigos data.New Feature: Describe Odigos
frontend/webapp/components/describe-odigos/index.tsx
: Added theDescribeOdigos
component which includes an icon button to trigger the display of Odigos information.frontend/webapp/graphql/queries/describe.ts
: Created a new GraphQL queryDESCRIBE_ODIGOS
to fetch Odigos data.frontend/webapp/hooks/describe/useDescribeOdigos.ts
: Added a custom hookuseDescribeOdigos
to use theDESCRIBE_ODIGOS
query.Component Integration
frontend/webapp/components/main/header/index.tsx
: Integrated theDescribeOdigos
component into the main header. [1] [2]frontend/webapp/components/overview/all-drawers/index.tsx
: Updated theAllDrawers
component to include a case forDRAWER_OTHER_TYPES.DESCRIBE_ODIGOS
, which renders theDescribeDrawer
component. [1] [2]Reusable Component Enhancements
frontend/webapp/reuseable-components/icon-button/index.tsx
: Created a newIconButton
component with optional ping animation to be used in various parts of the application.Code Refactoring and Cleanup
frontend/webapp/components/index.ts
: Reordered exports for better organization and added export for the newdescribe-odigos
component.frontend/webapp/components/notification/notification-manager.tsx
: Replaced the customBellIcon
with the newIconButton
component for consistency. [1] [2]frontend/webapp/containers/main/overview/overview-drawer/index.tsx
: Made several properties optional and added conditional checks to handle undefined properties gracefully. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]