[GEN-2012]: Add TLS support for Jaeger (v1 & v2) #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
reviewed
Dec 18, 2024
|
@blumamir I made all the necessary changes 😄 |
blumamir
reviewed
Dec 19, 2024
| The endpoint format is `host:port`. | ||
| - host is required | ||
| - port is optional and defaults to the default OTLP gRPC port `4317`. | ||
| - **JAEGER_URL** - Endpoint, the format is `host:port`. |
There was a problem hiding this comment.
I wonder if we should use the code name here JAEGER_URL or the display name
There was a problem hiding this comment.
Key name makes most sense to me, it's also self explanatory.
…certificate requirements
|
@blumamir sorted the nits too 👍 |
blumamir
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance Jaeger configuration, improve TLS support, and update the frontend for dynamic field handling. The most important changes are summarized below:
Jaeger Configuration Enhancements:
common/config/jaeger.go: Added new constantsJaegerTlsKeyandJaegerCaPemKey, and updated error messages for better clarity.common/config/jaeger.go: ModifiedModifyConfigfunction to support both secure and insecure connections, and added validation for TLS configuration.common/config/utils.go: AddedparseEncryptedOtlpGrpcUrlfunction to handle and validate encrypted OTLP gRPC URLs.Frontend Updates:
frontend/webapp/containers/main/destinations/destination-drawer/build-card.ts: Fixed the display of password fields to always show 11 dots for consistency.frontend/webapp/containers/main/destinations/destination-form-body/dynamic-fields/index.tsx: Added support for rendering checkbox input type in dynamic fields.frontend/webapp/hooks/destinations/useConnectDestinationForm.ts: Updated hook to handle checkbox input type.frontend/webapp/utils/constants/string.tsx: AddedCHECKBOXtoINPUT_TYPESconstants.Documentation Updates:
docs/backends/jaeger.mdx: Updated Jaeger configuration documentation to include new TLS-related fields and improved formatting. [1] [2]These changes collectively improve the configuration flexibility and security of Jaeger integrations, while also enhancing the frontend user experience.