Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2066]: remove null values from describe #2026

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

BenElferink
Copy link
Contributor

This pull request introduces a new utility function removeNoValues and integrates it into the Code component to improve JSON handling. The most important changes include the addition of the removeNoValues function, its export, and its use in the Code component with useMemo to optimize performance.

New utility function:

Integration of removeNoValues:

Copy link

Copy link
Collaborator

@alonkeyval alonkeyval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name removeNoValues could be more descriptive of what the function actually does. other then that looks great

@BenElferink BenElferink enabled auto-merge (squash) December 19, 2024 08:53
@BenElferink BenElferink merged commit 19d228e into odigos-io:main Dec 19, 2024
31 checks passed
@BenElferink BenElferink deleted the gen-2066 branch January 6, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants