[GEN-2065]: fix bug where UI crashed on attempt to edit "debug destination" #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
frontend/webapp/containers/maindirectory, focusing on improving the handling of form items and destination types. The most important changes include removing unnecessary return statements, adding optional parameters, and renaming variables for clarity.Improvements to form item handling:
frontend/webapp/containers/main/actions/action-drawer/index.tsx: Removed an unnecessary return statement when no matching item is found.frontend/webapp/containers/main/instrumentation-rules/rule-drawer/index.tsx: Removed an unnecessary return statement when no matching item is found.Enhancements to destination handling:
frontend/webapp/containers/main/destinations/destination-drawer/build-card.ts: Added an optional parameter to thebuildCardfunction to handle cases wheredestinationTypeDetailsmay be undefined.frontend/webapp/containers/main/destinations/destination-drawer/index.tsx: Updated thecardDatamemoization logic to handle cases wheredestinationTypeDetailsis not provided.frontend/webapp/containers/main/destinations/destination-drawer/index.tsx: RenamedthisDestinationtothisDestinationTypefor clarity and updated the corresponding references.