[GEN-1286]: Refactor configuration handling to replace deprecated dropdowns with checkboxes for Clickhouse, Gigapipe and Qryn destinations #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith boolean values for Clickhouse and Qryn destinations
…d function for boolean conversion, replacing deprecated string values
… fields and improve readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the configuration handling and documentation for the Clickhouse and Qryn destinations. The main focus is on updating deprecated values and improving the handling of boolean configurations.
Configuration Handling Improvements:
common/config/clickhouse.go: Replaced direct boolean conversion with a helper functiongetBooleanConfigforcreate_schemaconfiguration.common/config/qryn.go: Updated theModifyConfigfunction to use pre-parsed configuration values and replaced string comparisons with boolean values usinggetBooleanConfig. [1] [2] [3]common/config/qryn_oss.go: Deprecated "Yes/No" values in favor of "true/false" forresourceToTelemetryConversionandaddExporterNameconfigurations.common/config/utils.go: Added a new utility functiongetBooleanConfigto handle deprecated boolean configuration values.Documentation Updates:
docs/backends/clickhouse.mdx: Updated documentation to reflect the change from "Create/Skip" to "true/false" for theCreate Schemeconfiguration. [1] [2] [3] [4]docs/backends/gigapipe.mdx,docs/backends/qryn.mdx: Updated documentation to reflect the change from "Yes/No" to "true/false" for boolean configurations. [1] [2]UI and Frontend Adjustments:
frontend/webapp/hooks/compute-platform/useComputePlatform.ts: Replaced deprecated string values with boolean values for Clickhouse and Qryn configurations.frontend/webapp/hooks/destinations/useDestinationCRUD.ts: Ensured that undefined values are filtered out when creating or updating destinations.YAML Specification Changes:
destinations/data/clickhouse.yaml,destinations/data/gigapipe.yaml,destinations/data/qryn.yaml: Changed component types from dropdown to checkbox for boolean configurations and updated initial values accordingly. [1] [2] [3] [4]