Introduce Source CRD #2037
Merged
Introduce Source CRD #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
force-pushed
the
instrumentation-crd
branch
6 times, most recently
from
fe4ab19 to
ffbe6d9
Compare
blumamir
reviewed
Dec 20, 2024
RonFed
reviewed
Dec 20, 2024
damemi
force-pushed
the
instrumentation-crd
branch
3 times, most recently
from
04ae41f to
28acc08
Compare
damemi
force-pushed
the
instrumentation-crd
branch
from
28acc08 to
8d72fea
Compare
RonFed
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
SourceCRD that will be used to enable auto instrumentation for a workload (vs the current label approach). Based on design docThis doesn't hook the CRD up to anything yet or enable any functionality based on it. That will be done in a feature branch to collaborate with frontend. This PR is meant to break the change into a logical chunk, but also to unblock other work that can rely on this API type.