Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: narrow RBAC permissions for instrumentor #2042

Merged
merged 8 commits into from
Dec 21, 2024

Conversation

blumamir
Copy link
Collaborator

  • move things we use only in namespace from clusterrole to role.
  • reduce permission we don't need
  • remove permissions we don't use
  • sync controller-runtime cache with these changes.

This PR only touches the permissions, there are some opportunities to improve more, not in this PR scope.

@blumamir blumamir requested a review from RonFed December 20, 2024 12:47
- get
- list
- patch
- update
- watch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@blumamir blumamir merged commit 5f3b442 into odigos-io:main Dec 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants