Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test other agent #2081

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Test other agent #2081

merged 3 commits into from
Dec 29, 2024

Conversation

tamirdavid1
Copy link
Collaborator

No description provided.

RonFed
RonFed reviewed Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@RonFed RonFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the count in wait-for-traces files?

tests/e2e/workload-lifecycle/services/python-http-server/Dockerfile.python-other-agent

COPY entrypoint.sh /entrypoint.sh

ENV NEW_RELIC_CONFIG_FILE=/app/newrelic.ini
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the /newrelic.ini file present in the repo? couldn't find it

@tamirdavid1
Copy link
Collaborator Author

Do we need to update the count in wait-for-traces files?

We detect is using env var so don't really need it in the test

@tamirdavid1 tamirdavid1 merged commit df7f73a into odigos-io:main Dec 29, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamirdavid1 @RonFed