Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Namespace Source instrumentation #2105
Add Namespace Source instrumentation #2105
Changes from all commits
7ef4d94
e0320fa
e0a96bc
2bf63a8
57b61c5
c228058
ea8ac3c
8676015
253d622
35ea009
ba56913
0bc6c26
1b26c5a
f1ac129
ef48c59
4277faa
1ea0bb2
7295ac9
eeefef5
626e042
5bffb1e
27a767c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check only says if a workload instrumentation is inherited from ns. not if it's effectively instrumented or not.
It used to be ok because of this which guaranteed that this function is called after we already know the namespace is not labeled.
I think that the changes in this PR renders this assumption invalid, and we can now
deleteWorkloadInstrumentationConfig
andremoveReportedNameAnnotation
below even for instrumented workloads.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #2105 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the workload has a source CR, then it's not inheriting it's instrumentation from the ns, but this function can return
true
here instead offalse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like we talked about offline, this function and its use will be refactored in the backend label clean-up. Keeping this open as a reminder to do that