Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove instrumentedApplication from instrumentor/instrumentationconfig #2126

Merged
merged 3 commits into from
Jan 5, 2025
Merged

Remove instrumentedApplication from instrumentor/instrumentationconfig #2126

merged 3 commits into from
Jan 5, 2025

Conversation

RonFed
Copy link
Collaborator

@RonFed RonFed commented Jan 4, 2025 •
edited
Loading

  • When updating the instrumentationConfig spec (e.g. SdkConfigs) rely on the runtime detauls written in the status of the instrumentationConfig.
  • Create a common predicate to the instrumentor controller which passes events where the runtime details in the instrumentationConfig have been updated - currently only checking the length of the slice and this will be improved in the future.

@RonFed RonFed requested a review from blumamir January 4, 2025 14:08
@RonFed RonFed merged commit 40959c0 into odigos-io:main Jan 5, 2025
31 checks passed
@RonFed RonFed deleted the remove_inst_app_from_instrumentor branch January 5, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blumamir blumamir blumamir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonFed @blumamir