Run device manager outside of the error group #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
approved these changes
Jan 8, 2025
odiglet/odiglet.go
Outdated
Comment on lines
115
to
117
| log.Logger.V(0).Info("Device manager exited") | ||
| return err | ||
| }) | ||
| if err != nil { | ||
| log.Logger.Error(err, "Device manager exited with error") |
There was a problem hiding this comment.
nit: when existed with error, we will have 2 log lines for this:
Device manager exited
Device manager exited with error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device manager library doesn't support passing a context, hence it can't be canceled by the error group.
To avoid blocking Odiglet in case of a fatal error, the device manager is changed to run in a "regular" goroutine.