[GEN-2175]: optimize metrics fetching based on available sources and destinations #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenElferink
changed the title
RonFed
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
useMetricshook in thefrontend/webapp/hooks/overview/useMetrics.tsfile to improve its functionality by ensuring that metrics are only fetched when there are sources or destinations available.Improvements to
useMetricshook:frontend/webapp/hooks/overview/useMetrics.ts: Modified theuseMetricshook to use theuseSourceCRUDanduseDestinationCRUDhooks for fetching sources and destinations, and updated theskipcondition in theuseQuerycall to prevent fetching metrics when there are no sources or destinations.