Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2181]: enhance samplers input-validation with isEmpty function #2161

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

BenElferink
Copy link
Contributor

@BenElferink BenElferink commented Jan 8, 2025

This pull request introduces the isEmpty utility function and integrates it across various components to improve the handling of empty values. The most important changes include the addition of the isEmpty function, its use in form validation, and updates to the ErrorSampler and ProbabilisticSampler components to handle empty values more effectively.

Introduction of isEmpty utility function:

Integration of isEmpty in form components:

Form validation improvements:

Updates to reusable components:

Copy link

@BenElferink BenElferink requested a review from alonkeyval January 8, 2025 11:47
@BenElferink BenElferink added bug Something isn't working frontend labels Jan 8, 2025
@blumamir blumamir merged commit 26d1cbe into odigos-io:main Jan 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants