Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Source defaulting and validating webhooks #2167

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Add Source defaulting and validating webhooks #2167

merged 8 commits into from
Jan 8, 2025

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Jan 8, 2025 •
edited
Loading

Adds webhooks for Source objects:

  • Defaulting: set labels on Source to identify workload and finalizers for deletion
  • Validating: ensure Sources are unique and workload identifying fields are immutable (labels and spec.workload)

@damemi damemi mentioned this pull request Jan 8, 2025
Merged
@damemi damemi requested review from blumamir and RonFed January 8, 2025 18:50
@damemi damemi enabled auto-merge (squash) January 8, 2025 19:21
@damemi damemi requested a review from BenElferink January 8, 2025 19:43
@damemi damemi merged commit 68ffdcb into odigos-io:feature/source-crd Jan 8, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenElferink BenElferink BenElferink approved these changes

@blumamir blumamir Awaiting requested review from blumamir

@RonFed RonFed Awaiting requested review from RonFed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damemi @BenElferink