Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deployment and StatefulSet Name Collision #58

Merged
merged 4 commits into from
Jan 28, 2023

Conversation

eugercek
Copy link
Contributor

@eugercek eugercek commented Jan 24, 2023

Fixes #8

@eugercek
Copy link
Contributor Author

Hi @edeNFed AFAIK since crd names become url for the API server, they must be lowercase. I'm moving to:

  • deployment-name
  • statefulset-name

Example error message

1.674601193620897e+09   ERROR   controller.deployment   error creating InstrumentedApp object   {"reconciler group": "apps", "reconciler kind": "Deployment", "name": "redis-cart", "namespace": "default", "error": "InstrumentedApplication.odigos.io \"Deployment-redis-cart\" is invalid: metadata.name: Invalid value: \"Deployment-redis-cart\": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')"}

> RFC 1123 subdomain must consist of lower case alphanumeric character
@edeNFed
Copy link
Contributor

edeNFed commented Jan 25, 2023

tested on my machine and it works great.
Looks good to me, feel free to merge if you finished
Thanks!

@eugercek
Copy link
Contributor Author

eugercek commented Jan 25, 2023

I was going to test, thanks for your time. I finished but don't have merge permission can you merge

@edeNFed edeNFed merged commit 1b2e8e7 into odigos-io:main Jan 28, 2023
@edeNFed
Copy link
Contributor

edeNFed commented Jan 28, 2023

Merged, thank you @eugercek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment and StatefulSet with same name may overwrite each other
2 participants