new generic event trait #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 84.14% 85.32% +1.17%
==========================================
Files 39 39
Lines 3097 3386 +289
==========================================
+ Hits 2606 2889 +283
- Misses 491 497 +6 ☔ View full report in Codecov by Sentry. |
|
I just implemented these manually. |
TTWNO
force-pushed
the
new-generic-event-trait
branch
from
6ce4132 to
86c59f0
Compare
|
For those reviewing: I'm particularly interested in:
|
TTWNO
force-pushed
the
new-generic-event-trait
branch
from
a91966a to
9a33529
Compare
…o-impl for BusProperties
Cargo format Clippy
1. BusProperties. This contains static information about the DBus properties of a particular event type. This is implemented for indivudal event types only and is NOT object safe; it is similar to GenericEvent, but without path() and sender() functions. - DBUS_MEMBER - DBUS_INTERFACE - MATCH_RULE_STRING - REGISTRY_EVENT_STRING - type Body - build() function 2. EventTypeProperties. This is an object-safe trait that specifies similar data as BusProperties, but as runtime functions instead of constants. This will be implemented on individual event types, and wrapper types like `Event`. - member() -> &'static str - interface() -> &'static str - match_rule() -> &'static str - registry_string() -> &'static str - EventProperties is blanket implemented for any type that implenents BusPropeties. 3. EventProperties. This is an object-safe trait specifying qualities of a particular event, not its type. - name() -> BusName<'_> - path() -> ObjectPath<'_> - object_ref() -> ObjectRef (auto-impl) This fixes #176, addresses, at least in part #148.
Whoopsie
fmt Fix tests
TTWNO
force-pushed
the
new-generic-event-trait
branch
from
870af7c to
37612f7
Compare
|
Forgot that Github's "resolve conflicts" feature merges from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #177
Still TODO before ready:
static_assertions(no new deps, we already depend on this)