Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change get_mdiz_order method call name with attribute; fix #190 #192

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented Jun 16, 2024

No description provided.

@TTWNO
Copy link
Member Author

TTWNO commented Jun 16, 2024

@luukvanderduim Can you please confirm that this works?

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.51%. Comparing base (eaa55b1) to head (aeb5b4f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files          39       39           
  Lines        3344     3344           
=======================================
  Hits         2893     2893           
  Misses        451      451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luukvanderduim
Copy link
Collaborator

@luukvanderduim Can you please confirm that this works?

This adaptation of fama11y-tree tries to call get_mdiz_order on all objects that support Component.
Looks like the call works, though we only gain a 'now working call' as no single object seems to report anything over 0.

https://github.com/luukvanderduim/fama11y-tree/tree/rename-mdiz-layer-method-test

@TTWNO TTWNO merged commit 6cbe950 into main Jun 25, 2024
13 checks passed
@TTWNO TTWNO deleted the rename-mdiz-layer-method branch June 25, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants