-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types crate v2 #82
Types crate v2 #82
Conversation
…t for most custom event types
Please rebase and update enumflags2. |
Enumflags2 was downgraded in #87 are you wanting me to reverse that change? |
Also, I have merged main into this branch instead of rebasing, since that was the recommended step from the Github interface. I can also rebase if you'd like that better. |
Ah ha! Finally found the culprit! I probably need to move a few more things to be workspace deps, but now the tests finally work! Only took a dozen tries 😆 |
Fixed enumflags2; I didn't realize that the version had been upgraded not downgraded. My bad. P.S.: This code coverage report is super clear now that we can see the different subcrates: https://app.codecov.io/gh/odilia-app/atspi/pull/82/tree |
… been automated due to new macros and the GenericEvent trait
…erted to the Event enum
…t behaviour and is a bug in how we send events
I know this breaks the CI, but could we merge this? The error is a sign of another bug that needs to be addressed. I'll help merge the other PRs once this is merged. |
I'm going to merge this. This PR is blocking too many other PRs, development of Odilia, and general progress. I'm happy to continue submitting smaller PRs after this, but I'm happy with this in its current state, and it has all the changes applied to main since the branch. |
-types
into their own crate. This crate should be compileable on basically any system.-client
into its own crate. This crate is the equivalent of the old "client-accessories" features.--workspace
flag.