Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types crate v2 #82

Merged
merged 143 commits into from
Jun 16, 2023
Merged

Types crate v2 #82

merged 143 commits into from
Jun 16, 2023

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented May 11, 2023

  • Separate -types into their own crate. This crate should be compileable on basically any system.
  • Separate -client into its own crate. This crate is the equivalent of the old "client-accessories" features.
  • Fix all clippy warnings, add --workspace flag.
  • Fix semver checks (it only work on a crate-by-crate basis)
  • Approval from other involved individuals.

TTWNO added 30 commits April 29, 2023 23:45
@DataTriny
Copy link
Collaborator

Please rebase and update enumflags2.

@TTWNO
Copy link
Member Author

TTWNO commented Jun 12, 2023

Enumflags2 was downgraded in #87 are you wanting me to reverse that change?

@TTWNO
Copy link
Member Author

TTWNO commented Jun 12, 2023

Also, I have merged main into this branch instead of rebasing, since that was the recommended step from the Github interface. I can also rebase if you'd like that better.

@TTWNO
Copy link
Member Author

TTWNO commented Jun 12, 2023

Ah ha! Finally found the culprit!

I probably need to move a few more things to be workspace deps, but now the tests finally work! Only took a dozen tries 😆

@TTWNO
Copy link
Member Author

TTWNO commented Jun 12, 2023

Fixed enumflags2; I didn't realize that the version had been upgraded not downgraded. My bad.

P.S.: This code coverage report is super clear now that we can see the different subcrates: https://app.codecov.io/gh/odilia-app/atspi/pull/82/tree

@TTWNO
Copy link
Member Author

TTWNO commented Jun 13, 2023

I know this breaks the CI, but could we merge this? The error is a sign of another bug that needs to be addressed.

I'll help merge the other PRs once this is merged.

@TTWNO TTWNO requested a review from DataTriny June 13, 2023 12:44
@TTWNO
Copy link
Member Author

TTWNO commented Jun 16, 2023

I'm going to merge this. This PR is blocking too many other PRs, development of Odilia, and general progress. I'm happy to continue submitting smaller PRs after this, but I'm happy with this in its current state, and it has all the changes applied to main since the branch.

@TTWNO TTWNO merged commit 09a2e88 into main Jun 16, 2023
@TTWNO TTWNO deleted the types_crate_v2 branch June 16, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants