Restore set/get of SO_RCVBUF socket option in frame receiver UDP RX thread #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgdls
approved these changes
Mar 19, 2021
ulrikpedersen
approved these changes
Mar 19, 2021
|
Is it possible to use both of these options? |
|
I'm not sure what you mean @GDYendell ? |
|
Sorry. Is it possible to keep SO_REUSEADDR enabled rather than replacing it? Or are they not compatible? |
|
SO_REUSEADDR has no utility on a UDP socket unless you're using broadcast/multicast, to allow multiple processes to bind to the same port. The TIME_WAIT issue only affects closing TCP sockets. |
|
Ahh. Yes OK, I didn't spot that this is only in the UDP child class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #271 and fixes the regression in setting the receive buffer size on the UDP socket in the receive thread of the frame receiver.
The readback/reporting of the buffer size now also includes a divide by two to account for the kernel allocation behaviour, so that the true buffer size available is reported in matches the requested size.