Fix elapsed time calculation in live view rate settiing. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The elapsed time calcuation relies on truncating a posix_time duration to milliseconds as an int_32, which can fail with an incorrect value on the initial frame, or if the frame processor has been idling for long periods. To resolve this, the time since last frame variable is now stored and compared as a time_duration.
ajgdls
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elapsed time calcuation relies on truncating a posix_time duration to milliseconds as an int_32, which can fail with an incorrect value on the initial frame, or if the frame processor has been idling for long periods. To resolve this, the time since last frame variable is now stored and compared as a time_duration.
Also tidied up the live view decision logic so that the elapsed time is only calculated if the per_second rate setting is active