-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing shared dir in new odin release odin-windows-amd64-dev-2024-10 #4384
Comments
I skimmed the latest changes and don't immediately know why it's not there 🤔 |
Hmm may be the recent changes where hidden files are excluded from upload-artifact (iirc), the only file there is .gitkeep, and then you'd have an empty directory, which may be excluded too? actions/upload-artifact#602 |
I have no idea on how GH actions works, so pass on me. |
May be fixed in that commit, I will check and reopen if not |
Probably caused by actions/upload-artifact#602 Possibly fixes odin-lang#4384
\shared
was present in previous GH releaseodin-windows-amd64-dev-2024-9
, but not in the currentodin-windows-amd64-dev-2024-10
. This broke OLS usingodin check
as OLS looks for that dir, here is the relevant issue: DanielGavin/ols#527I was told in the Discord by laytan
\shared
probably shouldn't be missing, so here I am.The text was updated successfully, but these errors were encountered: