Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing shared dir in new odin release odin-windows-amd64-dev-2024-10 #4384

Closed
kulkalkul opened this issue Oct 16, 2024 · 4 comments
Closed

Comments

@kulkalkul
Copy link

\shared was present in previous GH release odin-windows-amd64-dev-2024-9, but not in the current odin-windows-amd64-dev-2024-10. This broke OLS using odin check as OLS looks for that dir, here is the relevant issue: DanielGavin/ols#527

I was told in the Discord by laytan \shared probably shouldn't be missing, so here I am.

@laytan
Copy link
Collaborator

laytan commented Oct 17, 2024

I skimmed the latest changes and don't immediately know why it's not there 🤔

@laytan
Copy link
Collaborator

laytan commented Oct 17, 2024

Hmm may be the recent changes where hidden files are excluded from upload-artifact (iirc), the only file there is .gitkeep, and then you'd have an empty directory, which may be excluded too? actions/upload-artifact#602

@kulkalkul
Copy link
Author

I have no idea on how GH actions works, so pass on me.

@laytan laytan closed this as completed in b82f8df Oct 17, 2024
@laytan
Copy link
Collaborator

laytan commented Oct 17, 2024

May be fixed in that commit, I will check and reopen if not

flysand7 pushed a commit to flysand7/Odin that referenced this issue Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants