Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CircleCI build test #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DreamyPhobic
Copy link
Collaborator

These tests will ensure our error-free workflow as well as will maintain our code quality.

Added .circleci build test.

Corrected the path of build.gradle file
added Code Quality tests

quality plugin added
@DreamyPhobic
Copy link
Collaborator Author

@jbeorse @linl33 please review?

@jbeorse
Copy link
Collaborator

jbeorse commented Mar 28, 2019

We appreciate your work on this, but this kind of change requires a discussion and decision from the ODK 2 (recently renamed ODK-X) community about whether we want to use CircleCI or not. Currently the rest of the ODK-X tools use Jenkins for continuous integration. I will leave this open for now while the matter can be discussed, but this will take time and this PR will not likely be merged in the short term. Please stick to the labeled issues or suggest changes in Slack. We do appreciate your efforts, but we want to make sure it gets applied where it can be most useful.

@DreamyPhobic
Copy link
Collaborator Author

Yeah, I know these kinds of changes need discussion but this repo has no way to check the build errors due to this may be it would result in mistakenly merging the wrong commit. That's why I felt the need for some basic build test. But yeah, you are right about discussion after all you have a better understanding of ODK-X toolsets than me. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants