Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Inventory: Fixing reordering rules navigation for 18.0 #11614

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

benderliz
Copy link
Contributor

@robodoo
Copy link
Collaborator

robodoo commented Dec 19, 2024

Pull request status dashboard

@benderliz benderliz self-assigned this Dec 19, 2024
@benderliz benderliz added the 2 label Dec 19, 2024
@benderliz
Copy link
Contributor Author

Hi @StraubCreative! Just going to go ahead and request your review on this PR since you reviewed its 17.0 sister :) I edited the navigation link and implemented your suggestions from the 17.0 one here, as well as made sure the field names lined up with the 18.0 UI. Thank you!

@C3POdoo C3POdoo requested a review from a team December 19, 2024 18:42
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @benderliz
Just a couple quick RST fixes and you're good to merge again 👍

I'm going to close the 18.0 forward-port of the other one so there's no merge conflict.
Delegating this one to you, thanks!

@robodoo delegate=benderliz

- :guilabel:`Multiple Quantity`: Specify if the product should be replenished in batches of a
certain quantity (e.g., a product could be replenished in batches of 20).
- :guilabel:`Max`: The maximum quantity at which the stock is replenished.
- :guilabel:`To Order`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the definition for this field is missing 🙈

Suggested change
- :guilabel:`To Order`:
- :guilabel:`To Order`: The number of units, according to the *UoM* that should be replenished for
certain quantity (e.g., a product could be replenished in batches of 20).

:alt: The form for creating a new reordering rule.

.. note::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good note 👍

Comment on lines +64 to +66
To create a new reordering rule, navigate to
:menuselection:`Inventory app --> Operations --> Replenishment`, then click :guilabel:`New`,
and fill out the following fields for the new reordering rule line item:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can break menuselection midway through the tag, see the Tip and Example here in the rst guidelines.

Suggested change
To create a new reordering rule, navigate to
:menuselection:`Inventory app --> Operations --> Replenishment`, then click :guilabel:`New`,
and fill out the following fields for the new reordering rule line item:
To create a new reordering rule, navigate to :menuselection:`Inventory app --> Operations -->
Replenishment`, then click :guilabel:`New`, and fill out the following fields for the new
reordering rule line item:

Comment on lines +89 to +90
specifies if the product should be replenished in batches of a certain quantity
(e.g., a product could be replenished in batches of 20).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

early line break

Suggested change
specifies if the product should be replenished in batches of a certain quantity
(e.g., a product could be replenished in batches of 20).
specifies if the product should be replenished in batches of a certain quantity (e.g., a product
could be replenished in batches of 20).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants