-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Inventory: Fixing reordering rules navigation for 18.0 #11614
base: 18.0
Are you sure you want to change the base?
Conversation
Hi @StraubCreative! Just going to go ahead and request your review on this PR since you reviewed its 17.0 sister :) I edited the navigation link and implemented your suggestions from the 17.0 one here, as well as made sure the field names lined up with the 18.0 UI. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @benderliz
Just a couple quick RST fixes and you're good to merge again 👍
I'm going to close the 18.0 forward-port of the other one so there's no merge conflict.
Delegating this one to you, thanks!
@robodoo delegate=benderliz
- :guilabel:`Multiple Quantity`: Specify if the product should be replenished in batches of a | ||
certain quantity (e.g., a product could be replenished in batches of 20). | ||
- :guilabel:`Max`: The maximum quantity at which the stock is replenished. | ||
- :guilabel:`To Order`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the definition for this field is missing 🙈
- :guilabel:`To Order`: | |
- :guilabel:`To Order`: The number of units, according to the *UoM* that should be replenished for | |
certain quantity (e.g., a product could be replenished in batches of 20). |
:alt: The form for creating a new reordering rule. | ||
|
||
.. note:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good note 👍
To create a new reordering rule, navigate to | ||
:menuselection:`Inventory app --> Operations --> Replenishment`, then click :guilabel:`New`, | ||
and fill out the following fields for the new reordering rule line item: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can break menuselection midway through the tag, see the Tip and Example here in the rst guidelines.
To create a new reordering rule, navigate to | |
:menuselection:`Inventory app --> Operations --> Replenishment`, then click :guilabel:`New`, | |
and fill out the following fields for the new reordering rule line item: | |
To create a new reordering rule, navigate to :menuselection:`Inventory app --> Operations --> | |
Replenishment`, then click :guilabel:`New`, and fill out the following fields for the new | |
reordering rule line item: |
specifies if the product should be replenished in batches of a certain quantity | ||
(e.g., a product could be replenished in batches of 20). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
early line break
specifies if the product should be replenished in batches of a certain quantity | |
(e.g., a product could be replenished in batches of 20). | |
specifies if the product should be replenished in batches of a certain quantity (e.g., a product | |
could be replenished in batches of 20). |
Doc task # 4411255