Skip to content

[IMP] VoIP: Call queues changes #12814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

justinmallette
Copy link
Contributor

Update call queues doc. Fix inaccuracies

https://www.odoo.com/odoo/project/3835/tasks/4710192

@justinmallette justinmallette self-assigned this Apr 7, 2025
@robodoo
Copy link
Collaborator

robodoo commented Apr 7, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team April 7, 2025 16:43
@justinmallette justinmallette requested a review from jero-odoo April 7, 2025 16:59
@justinmallette
Copy link
Contributor Author

hi @jero-odoo this one's ready for review!

Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @justinmallette great work, just some formatting comments and a couple of suggestions.
Before submitting for final I would double check make review to make sure there are no other issues with the line breaks. Let me know if you have any questions, thanks!

Comment on lines 88 to 89
<https://manage.axivox.com>`_, and click :guilabel:`Queues` from the left-hand menu. Then,
click the green :guilabel:`Refresh` button at the top of the :guilabel:`Connected agents` column.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early line break (under 100 characters)

Comment on lines 90 to 91
From here, click the red :guilabel:`Disconnect` button, and they are
immediately disconnected. This can be helpful in situations where agents forget to log out at the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early line break (under 100 characters)

Comment on lines 131 to 132
Any or all of the 13 options can be selected from the :guilabel:`Event type` drop-down
menu. Clicking :guilabel:`Check all` selects all the available options from the drop-down menu, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early line break (under 100 characters)

Comment on lines 162 to 163
column. Any agent (static or dynamic) that is connected to the queue currently appears in the
column next to the queue they are logged into.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early line break (under 100 characters)

Comment on lines 166 to 167
number, and then press the green call button :icon:`fa-phone` :guilabel:`(phone)` icon. The agent is
disconnected from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early line break (under 100 characters)

the queue after a short, two-second message.

To manually log a dynamic agent out of a call queue, navigate to the `Axivox management console
<https://manage.axivox.com>`_, and click :guilabel:`Queues`, located in the left-hand column. Then,
click the green :guilabel:`Refresh` button at the top of the :guilabel:`Connected agents` column.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line (can be removed)

queue. Here are the options:

- :guilabel:`Call all available agents`
- :guilabel:`Calls the agent who has received the call for the longest time`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know for the most part these are all pretty self explanatory, but do you think it is worth it to explain them a bit? I am thinking specifically this option, since it seems a bit odd to me (does it mean the person who has been working there the longest?)
Totally up to you, but wanted to put it out there.


There is no limit to how many options can be selected from the :guilabel:`Event type` drop-down
menu.
- :guilabel:`Blind Transfer` (when the caller is transferred without interacting with an agent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't access this part of the VoIP menu (I was able to log in to the testing database from a tutorial, but I don't want to risk messing anything up since I believe it is being used for a recording soon)
Is this formatting correct for this option? or is the part in parenthesis part of the guilable? If not, I would change this to :

@justinmallette justinmallette force-pushed the 18.0-call-queues-adjustments-juma branch from 35e309f to 003350d Compare April 7, 2025 20:02
@justinmallette
Copy link
Contributor Author

@Felicious ready for final review

@justinmallette justinmallette requested a review from Felicious April 7, 2025 20:20
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, @justinmallette !

Just completed a content review of this PR, and you've made good improvements overall on the doc for readability and clarity. I wasn't able to test the flow, since I didn't know which agent to dial in our Odoo runbot. I'll connect with you tomorrow for that information!

In the :guilabel:`Maximum duration of ringing at an agent` field, determine the longest time an
individual agent's line rings before moving on to another agent, or moving to the next step in the
dial plan. Enter a time in seconds.
:guilabel:`Add a queue`. From here, set up the call queue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a much better rewrite compared to what was here before! (: The information from other sections were pulled together and everything is organized in a better way!

Comment on lines 9 to 10
This document explains how to configure advanced call queue settings and log into a queue from the
Odoo database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the basic settings detailed in the avivox config doc?


#. Dynamic agents connect automatically.
#. Manager logs in specific agent(s), via the `Axivox management console
#. Static agents connect automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a static vs dynamic agent? Is this something that an industry expert would know? If so, there's no need to clarify (:

@justinmallette
Copy link
Contributor Author

Good work, @justinmallette !

Just completed a content review of this PR, and you've made good improvements overall on the doc for readability and clarity. I wasn't able to test the flow, since I didn't know which agent to dial in our Odoo runbot. I'll connect with you tomorrow for that information!

@Felicious you can use the database from this tutorial script for testing: https://docs.google.com/document/d/1Bi8khMb7HU3DduLB9NJukJAurMHCu0UqtxYx1zfedOQ/edit?tab=t.0

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @justinmallette ! Tested it in the database you provided, good job setting everything up 😊

@justinmallette justinmallette force-pushed the 18.0-call-queues-adjustments-juma branch from 235f9b0 to e82ed54 Compare April 10, 2025 20:16
@justinmallette
Copy link
Contributor Author

@samueljlieber ready for TR

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @justinmallette! Fantastic improvements to this doc 👏

I am approving with a comment about :guilabel:s, LMK your thoughts and please address before merge :)

Thank you for your work!
.....
@robodoo delegate=justinmallette

Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>
Co-authored-by: Felicia Kuan <feku@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@justinmallette justinmallette force-pushed the 18.0-call-queues-adjustments-juma branch from 8c3a866 to 1b812ac Compare April 29, 2025 15:08
@justinmallette
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants