[IMP] Inventory: DHL Developer Portal #12902
Conversation
|
|
|
@jero-odoo ready for peer review. it looks like the whole article was rewritten, but I'm just canonizing 16.0 to what 17.0 looks like. Lines 69-90 and 126-134 were what was actually updated, so those are the only snippets that need review. |
...tions/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/dhl_credentials.rst
Outdated
Show resolved
Hide resolved
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| A DHL SiteID, password, and account number are used to link a DHL account with third-party services, | ||
| like Odoo's **Inventory** app. The SiteID and password are different credentials than the ones used |
There was a problem hiding this comment.
This might be worth breaking out into an "Important" admonition block. Not a requirement, but something to consider!
...tions/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/dhl_credentials.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Great additions to this doc, @justinmallette! 🙌 I compared it to the 18.0 version, and there’s just a tiny merge conflict to resolve—just from where you cleaned up an unnecessary phrase, so nothing major.
I also reviewed your updates against the expert’s feedback, so no worries if she hasn’t replied yet—I’ve cross-checked it already. Really appreciate the thoroughness here! It’s clear you actually tested the DHL app creation flow on their third-party site—awesome job! 👏
|
|
||
| Getting SiteID and password for countries other than United States (UK and Rest of the world) | ||
| ============================================================================================= | ||
| Once the connector has been enabled, a :icon:`oi-arrow-right` :guilabel:`DHL Shipping Methods` link |
There was a problem hiding this comment.
the icon isn't rendering for some reason
Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>
justinmallette
force-pushed
the
16.0-inventory-dhl-connector-juma
branch
from
ff7f25a to
a952c5a
Compare
|
@samueljlieber ready for TR! |
There was a problem hiding this comment.
Looks great to me @justinmallette! Nice work :)
Approved 👍
..
@robodoo r+
closes #12902 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com> Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>
|
@justinmallette @samueljlieber staging failed: ci/runbot on 7ca8493bc41a84a2c9c1ea00f4768c0abbd1b25e (view more at https://runbot.odoo.com/runbot/build/78872023) |
|
@robodoo r+ |
|
@justinmallette you can't review+. |
|
@samueljlieber can you run robodoo on this one again? |
|
@justinmallette you just need to politely ask robodoo to retry :) @robodoo retry |
closes #12902 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com> Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>
|
@justinmallette @samueljlieber staging failed: ci/runbot on 5bf1f209ee8a9d132e428d09eb474b600fc70f11 (view more at https://runbot.odoo.com/runbot/build/79335482) |
|
@robodoo retry |
closes #12902 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com> Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>
Updating DHL connection doc
https://www.odoo.com/odoo/project/3835/tasks/4602231