[IMP] accounting: cheat sheet styles #13047
Conversation
|
|
static/css/accounting.css
Outdated
| @@ -11,15 +11,21 @@ main.index .toctree-wrapper > .row:first-child > .col-md-3 { | |||
| .doc-aside p{ | |||
| padding: .5rem; | |||
| } | |||
| .doc-aside div { | |||
| border: 1px solid rgba(255, 255, 255, 0); | |||
There was a problem hiding this comment.
I'm not sure what is the point of this. This will put an invisible border (?) What are we trying to achieve ?
It happens a lot in the pr.
There was a problem hiding this comment.
Hi @rugo-odoo, the reason I added an 1px invisible border is to avoid the 1px layout shift that happens when the 1px black border appears on hover :)
There was a problem hiding this comment.
I believe much of this is unnecessary.
-
For the one with
.highlight-op, we can just change the border color. We already have a border so it won't shift. -
If I'm not mistake, to prevent the shift, we can just use
box-sizing: border-boxfor the elements we need. border-box will not add any width/height with the border.
It will be cleaner and easier to maintain.
|
@robodoo delegate=rugo-odoo |
static/css/accounting.css
Outdated
| @@ -11,15 +11,21 @@ main.index .toctree-wrapper > .row:first-child > .col-md-3 { | |||
| .doc-aside p{ | |||
| padding: .5rem; | |||
| } | |||
| .doc-aside div { | |||
| border: 1px solid rgba(255, 255, 255, 0); | |||
There was a problem hiding this comment.
I believe much of this is unnecessary.
-
For the one with
.highlight-op, we can just change the border color. We already have a border so it won't shift. -
If I'm not mistake, to prevent the shift, we can just use
box-sizing: border-boxfor the elements we need. border-box will not add any width/height with the border.
It will be cleaner and easier to maintain.
samueljlieber
force-pushed
the
16.0-accounting-cheat-sheet-sali
branch
from
c71c50f to
e92d9c0
Compare
|
Hi @rugo-odoo! Thank you for your helpful suggestions :) in e92d9c0 I was able to replace the border color for For your second point, about using With these changes, things should be cleaner and easier to maintain! Thank you for pushing for changes :) ready for another look! 🙏 |
closes #13047 Signed-off-by: Ruben Gomes (rugo) <rugo@odoo.com>
Task: #4743756
FWP up to
masterThis PR improves the styles on the Accounting Cheat Sheet by adding borders which adds more contrast to the highlights.
As well as corrects the color of the Reconciliation button to use the Odoo primary and secondary colors: