[ADD] Employees: Onboarding #13129
[ADD] Employees: Onboarding #13129
Conversation
|
|
larm-odoo
force-pushed
the
18.0-employees-new-onboarding-larm
branch
from
4b70d15 to
7dae822
Compare
|
Hi @jero-odoo - this is ready for a peer review! |
There was a problem hiding this comment.
All set @larm-odoo! I left some comments (I would double check make review on some of the line breaks). Also I think there should be a mention as to what the users who are assigned the onboarding tasks see in their database, like the coaches and leads (see my note at the bottom). Let me know if you have any questions. Thanks!
| to complete the onboarding plan. The steps appear in a list view, and each step displays the | ||
| following information: | ||
|
|
||
| - :guilabel:`Activity Type`: the specific activity for the step. The default options are :guilabel:`Email`, |
There was a problem hiding this comment.
What's odd is that I did run make review- but it never catches this line, even though it looks like it's 110 long. I just checked again - an "no issues" is reported.
There was a problem hiding this comment.
Hmm I'm not sure what's causing the issue either 🤔 I identified it because i had a 100 character ruler
There was a problem hiding this comment.
Seems like the sphinx-lint max-line-length check has an issue detecting lines ending with a comma!
However, this line is still detected by the VS Code highlight and indicated as over 100 chars by the ruler.
larm-odoo
force-pushed
the
18.0-employees-new-onboarding-larm
branch
from
7dae822 to
5c0fd08
Compare
|
Hi @Felicious - this is ready for a final review! |
There was a problem hiding this comment.
Very detailed new doc, @larm-odoo ! Had some optional rewording suggestions for brevity for you to consider!
| to complete the onboarding plan. The steps appear in a list view, and each step displays the | ||
| following information: | ||
|
|
||
| - :guilabel:`Activity Type`: the specific activity for the step. The default options are :guilabel:`Email`, |
There was a problem hiding this comment.
Hmm I'm not sure what's causing the issue either 🤔 I identified it because i had a 100 character ruler
larm-odoo
force-pushed
the
18.0-employees-new-onboarding-larm
branch
from
5c0fd08 to
1c76077
Compare
|
This is ready for a tech review @samueljlieber =) |
There was a problem hiding this comment.
Looks good to me @larm-odoo, thank you for your work!
.....
@robodoo r+
No Onboarding doc currently exists.