-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[FW][ADD] tutorials/website_theme: Add tutorials to build a website theme #13131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cede-odoo @AntoineVDV cherrypicking of pull request #12573 failed. stdout:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
67c8452
to
fdb6828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something I should review in particular?
Except for the commits that should be squashed together and rewritten to look like a proper forward-port, I don't think I need to comment on anything else as I already reviewed the original version in 16.0.
For forward-port PRs, it's up to the author to decide whether the reviewer should make a second pass, for example when significant adaptations are made. If not, they can r+ themselves.
I don't think so, I was not sure @cede-odoo was able to r+ by herself without a new review. My bad, @AntoineVDV |
@robodoo r+ |
stdout: CONFLICT (modify/delete): content/developer/tutorials/website.rst deleted in 9f8b8e7 and modified in 5492d6e. Version 5492d6e of content/developer/tutorials/website.rst left in tree. stderr: Part-of: #13131 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Céline de Lannoy (cede) <cede@odoo.com>
[FIX] toctree: tutorials.rst [REM] Remove website.rst (no longuer in use) [FIX] dynamic_templates: reflink to variants closes #13131 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Céline de Lannoy (cede) <cede@odoo.com>
@robodoo r- Could you squash the commits? 🙏 |
fdb6828
to
44cd8aa
Compare
@AntoineVDV There you go |
This PR's commit still mentions other commits, "cherry pick failed", etc. Its commits should rather be like in the 16.0 PR |
44cd8aa
to
d99f4b3
Compare
d99f4b3
to
665bd09
Compare
@robodoo r+ |
@cede-odoo @AntoineVDV because this PR has multiple commits, I need to know how to merge it:
|
@robodoo r+ rebase-ff |
This PR is already reviewed, reviewing it again is useless. |
Merge method set to rebase and fast-forward. |
Part-of: #13131 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Céline de Lannoy (cede) <cede@odoo.com>
closes #13131 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Céline de Lannoy (cede) <cede@odoo.com>
Add a tutorial to learn how to create a website theme Odoo16
Based on the documentation 16.0: How-to guides -> Website themes
This tutorial is illustrated by a example module: the website theme of Airproof. It will be on the GitHub repository: /tutorials.
See also:
Forward-Port-Of: #12573