Skip to content

Conversation

ticodoo
Copy link
Contributor

@ticodoo ticodoo commented Oct 16, 2025

PR does 2 things:

  • Re-export pots, including if no terms have been updated due to some languages not being in sync with the pot file in Weblate (i.e. po files already existed and msgmerge is not run until Weblate detects a change in the pot file)
  • remove settings.pot + its translations/references since it appears to be leftover from v14 (i.e. was probably deleted in a refactoring). We remove it in stable so translators don't waste time translating things that are never seen by users.

Includes pot files with no term changes to force Weblate to correctly
sync the terms to translate within it (otherwise it uses what was in the
existing .po file which may be incorrect).

Note that for some reason the `applications.pot` and `index.pot` files
don't seem to be generated by the Sphinx gettext in this version, but
their terms have not changed since their last update. Therefore they
have been manually updated to ensure the forced Weblate sync.
settings.pot hasn't been exported since 14.0 and doesn't seem to
correspond to anything in the documentation anymore so it's probably
leftover from an old refactoring.

Note that an audit of the other pot files was done and this was the only
obsolete one found.
@robodoo
Copy link
Collaborator

robodoo commented Oct 16, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 16, 2025 15:28
Copy link
Contributor

@oomsveta oomsveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Oct 16, 2025

@ticodoo @oomsveta because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@oomsveta
Copy link
Contributor

robodoo rebase-ff

@robodoo
Copy link
Collaborator

robodoo commented Oct 16, 2025

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Oct 16, 2025
Includes pot files with no term changes to force Weblate to correctly
sync the terms to translate within it (otherwise it uses what was in the
existing .po file which may be incorrect).

Note that for some reason the `applications.pot` and `index.pot` files
don't seem to be generated by the Sphinx gettext in this version, but
their terms have not changed since their last update. Therefore they
have been manually updated to ensure the forced Weblate sync.

Part-of: #14882
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
robodoo pushed a commit that referenced this pull request Oct 16, 2025
settings.pot hasn't been exported since 14.0 and doesn't seem to
correspond to anything in the documentation anymore so it's probably
leftover from an old refactoring.

Note that an audit of the other pot files was done and this was the only
obsolete one found.

closes #14882

Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
@robodoo robodoo closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants