-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] marketing automation: audience targeting #8018
Conversation
Hi @ksc-odoo this PR is ready for a peer review when you get the chance, thank you in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright @samueljlieber -- just finished my peer review on this. awesome job! nicely done! only a handful of super minor things that require your attention. Once you make the necessary adjustments, I think you can feel free to move this to the next stage. Way to go! 👍
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
7dba31f
to
9d94cdd
Compare
Thank you @ksc-odoo for your super helpful review, I implemented your suggestions in 9d94cdd. @StraubCreative this PR is ready for a final content review when you have a chance, thank you! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samueljlieber
Great doc! I really like the example you used at the end to tie it all together.
Approving with comments— I have some suggestions for you to consider below, however we can merge whenever you're ready.
Thanks for your contribution! 🚀
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/marketing_automation/target_audience.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
9d94cdd
to
6b187bf
Compare
Thank you @StraubCreative for your insightful review! I implemented your suggestions in 6b187bf. I also removed a good portion of the configuring filters documentation since it is being improved in #8472, I added a reference to it instead. |
@robodoo r+ please :) |
Task: #3774153
This PR improves the
marketing_automation/target_audience.rst
documentation by documenting the steps to target an audience for a marketing automation campaign, specifically detailing how a domain is defined with an example.This PR can be FWP up to
master
.