-
Notifications
You must be signed in to change notification settings - Fork 81
[IMP] accounting_firm: add fields and custos for ID, AML and CSAM #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
67b2b6e to
0d5f42e
Compare
242ac8e to
49ba33b
Compare
vava-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
You'll need to rebase (error with cloc will disappear) and solve the conflict.
There is still an issue with runbot with a date field.
| for partner in records: | ||
| partner.message_post( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there another type of server action for generic actions like sending an email?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through the code for quite some time and couldn't find any other way to log a note for a record. Are you sure there's a special server action for that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
49ba33b to
7c404ab
Compare
Adds customizations and demo data to the accounting_firm app to implement additional aspects: - Identity document management features such as requesting documents button and scheduled action, and more fields to complete about ID - Anti-money Laundering (AML) tab in contact and additional model to evaluate risks - CSAM fields for additional information on contacts - More localized buttons on contact Task-5092478
7c404ab to
763eaf8
Compare
Hello ! For the date fields, as they are birth date field with values such as 1993-06-15, I thought it was not a bad idea to let them be hardcoded. Tell me what you think about it and if I should change it. |
| </record> | ||
| <record id="base_industry_data.res_partner_22" model="res.partner" forcecreate="False"> | ||
| <field name="ubo_national_identifier">BE246813579</field> | ||
| <field name="ubo_birth_date">1983-12-18</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, but I don't see any goo way to change the test. You could simply avoid it with something like
| <field name="ubo_birth_date">1983-12-18</field> | |
| <field name="ubo_birth_date" eval="datetime(1983, 12, 18).date()/> |


Adds customizations and demo data to the accounting_firm app to implement additional aspects:
Task-5092478