Skip to content

Conversation

@frva-odoo
Copy link
Contributor

@frva-odoo frva-odoo commented Oct 9, 2025

Adds customizations and demo data to the accounting_firm app to implement additional aspects:

  • Identity document management features such as requesting documents button and scheduled action, and more fields to complete about ID
  • Anti-money Laundering (AML) tab in contact and additional model to evaluate risks
  • CSAM fields for additional information on contacts
  • More localized buttons on contact

Task-5092478

@robodoo
Copy link
Collaborator

robodoo commented Oct 9, 2025

Pull request status dashboard

@frva-odoo frva-odoo force-pushed the 19.0-accounting-firm-id-aml-frva branch 3 times, most recently from 67b2b6e to 0d5f42e Compare October 10, 2025 14:54
@frva-odoo frva-odoo force-pushed the 19.0-accounting-firm-id-aml-frva branch from 242ac8e to 49ba33b Compare October 28, 2025 11:35
Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
You'll need to rebase (error with cloc will disappear) and solve the conflict.
There is still an issue with runbot with a date field.

Comment on lines +79 to +80
for partner in records:
partner.message_post(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there another type of server action for generic actions like sending an email?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the code for quite some time and couldn't find any other way to log a note for a record. Are you sure there's a special server action for that ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this working? You'd need a mail.template.
image

@frva-odoo frva-odoo force-pushed the 19.0-accounting-firm-id-aml-frva branch from 49ba33b to 7c404ab Compare November 4, 2025 14:37
Adds customizations and demo data to the accounting_firm app to implement additional aspects:
- Identity document management features such as requesting documents button and scheduled action, and more fields to complete about ID
- Anti-money Laundering (AML) tab in contact and additional model to evaluate risks
- CSAM fields for additional information on contacts
- More localized buttons on contact

Task-5092478
@frva-odoo frva-odoo force-pushed the 19.0-accounting-firm-id-aml-frva branch from 7c404ab to 763eaf8 Compare November 4, 2025 14:58
@frva-odoo frva-odoo changed the title [IMP] accounting_firm: add features for AML, ID and CSAM [IMP] accounting_firm: add fields and custos for ID, AML and CSAM Nov 4, 2025
@frva-odoo
Copy link
Contributor Author

Good! You'll need to rebase (error with cloc will disappear) and solve the conflict. There is still an issue with runbot with a date field.

Hello ! For the date fields, as they are birth date field with values such as 1993-06-15, I thought it was not a bad idea to let them be hardcoded. Tell me what you think about it and if I should change it.

</record>
<record id="base_industry_data.res_partner_22" model="res.partner" forcecreate="False">
<field name="ubo_national_identifier">BE246813579</field>
<field name="ubo_birth_date">1983-12-18</field>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, but I don't see any goo way to change the test. You could simply avoid it with something like

Suggested change
<field name="ubo_birth_date">1983-12-18</field>
<field name="ubo_birth_date" eval="datetime(1983, 12, 18).date()/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants