[FIX] functions: fix LINEST error massage #7109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
LucasLefevre
reviewed
Oct 1, 2025
hokolomopo
force-pushed
the
17.0-fix-some-function-error-messages-adrm
branch
from
8e1ff6c to
24c4f51
Compare
rrahir
reviewed
Oct 10, 2025
src/functions/helpers.ts
Outdated
| ); | ||
| } else if (typeof cell === "string") { | ||
| message = _t( | ||
| "Function [[FUNCTION_NAME]] expects number values for %s, but got an empty string.", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "Function [[FUNCTION_NAME]] expects number values for %s, but got an empty string.", | |
| "Function [[FUNCTION_NAME]] expects number values for %s, but got a string.", |
The functions using the helper `tryCastAsNumberMatrix` had a wrong
error message:
- the two arguments in the translated string were inverted
- an argument of `_t` was `typeof cell`, which isn't translated
- the other argument of the `_t` was something like
`the first argument (data_y)`, which wasn't translated either
Task: 5059375
rrahir
force-pushed
the
17.0-fix-some-function-error-messages-adrm
branch
from
24c4f51 to
c740df0
Compare
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 10, 2025
The functions using the helper `tryCastAsNumberMatrix` had a wrong
error message:
- the two arguments in the translated string were inverted
- an argument of `_t` was `typeof cell`, which isn't translated
- the other argument of the `_t` was something like
`the first argument (data_y)`, which wasn't translated either
closes #7109
Task: 5059375
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The functions using the helper
tryCastAsNumberMatrixhad a wrong error message:_twastypeof cell, which isn't translated_twas something likethe first argument (data_y), which wasn't translated eitherTask: 5059375
review checklist