Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Oct 13, 2025

Description:

Steps to reproduce:

  • Create a new sheet (Sheet2).
  • On Sheet1, open the Data Validation side panel.
  • Add a DV with type "isValueInRange".
  • Click on the selection input to select the range.
  • Navigate to Sheet2 and select the range.
  • Click on Save without confirming the ranges.

Before this PR:

  • The DV was created on Sheet2 instead of remaining on Sheet1.

After this PR:

  • The DV is correctly created on the original sheet (Sheet1).

Task: 4948201

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7146

@robodoo
Copy link
Collaborator

robodoo commented Oct 13, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Oct 13, 2025

@dhrp-odoo @LucasLefevre cherrypicking of pull request #7146 failed.

stdout:

Auto-merging src/components/side_panel/data_validation/dv_editor/dv_editor.ts
Auto-merging tests/data_validation/data_validation_generics_side_panel_component.test.ts
CONFLICT (content): Merge conflict in tests/data_validation/data_validation_generics_side_panel_component.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Steps to reproduce:
- Create a new sheet (Sheet2).
- On Sheet1, open the Data Validation side panel.
- Add a DV with type "isValueInRange".
- Click on the selection input to select the range.
- Navigate to Sheet2 and select the range.
- Click on Save without confirming the ranges.

Before this commit:
- The DV was created on Sheet2 instead of remaining on Sheet1.

After this commit:
- The DV is correctly created on the original sheet (Sheet1).

Task: 4948201
X-original-commit: 5395a3b
@dhrp-odoo dhrp-odoo force-pushed the 18.0-17.0-fix-dv-multi-sheet-range-selection-dhrp-463807-fw branch from b1e2065 to e6c4ea3 Compare October 13, 2025 12:33
@dhrp-odoo
Copy link
Contributor

robodoo r+

robodoo pushed a commit that referenced this pull request Oct 13, 2025
Steps to reproduce:
- Create a new sheet (Sheet2).
- On Sheet1, open the Data Validation side panel.
- Add a DV with type "isValueInRange".
- Click on the selection input to select the range.
- Navigate to Sheet2 and select the range.
- Click on Save without confirming the ranges.

Before this commit:
- The DV was created on Sheet2 instead of remaining on Sheet1.

After this commit:
- The DV is correctly created on the original sheet (Sheet1).

closes #7319

Task: 4948201
X-original-commit: 5395a3b
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
@robodoo robodoo closed this Oct 13, 2025
@fw-bot fw-bot deleted the 18.0-17.0-fix-dv-multi-sheet-range-selection-dhrp-463807-fw branch October 20, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants