Skip to content

Conversation

@rrahir
Copy link
Collaborator

@rrahir rrahir commented Nov 17, 2025

When we introduced the mobile mode, we started relying on the dynamic vewport height (dvh) to account for the resizing of the viewport when the virtual keyboard of a smarphone would pop up.

However, the rule we chose was to set the height of spreadsheet wrapper to 100dvh, which stands for 100% of the dynamic viewport height. As such, if we were to add some header before the Spreadsheet component, the latter would keep its size as 100% of the viewport, meaning that the full component is pushed downwards and it overflows from the page.

This revision places the 100dvh rule over the full page to account for any header that could be added in the future.

Task: 5212448

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

When we introduced the mobile mode, we started relying on the dynamic
vewport height (dvh) to account for the resizing of the viewport when
the virtual keyboard of a smarphone would pop up.

However, the rule we chose was to set the height of spreadsheet wrapper to
100dvh, which stands for 100% of the dynamic viewport height. As such,
if we were to add some header before the Spreadsheet component, the
latter would keep its size as 100% of the viewport, meaning that the
full component is pushed downwards and it overflows from the page.

This revision places the 100dvh rule over the full page to account for
any header that could be added in the future.

Task: 5212448
@robodoo
Copy link
Collaborator

robodoo commented Nov 17, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants