Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 18, 2025

Description:

Current behavior before PR:

  • When typing =sum( and pressing the Home key, selecting a range caused weird
    behavior in the composer.
  • The same issue occurred when using Ctrl+A to select the entire text.

Desired behavior after PR is merged:

  • Changing the cursor selection now correctly switches the mode to 'editing'.

Task: 5226615

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7400

@robodoo
Copy link
Collaborator

robodoo commented Nov 18, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 18, 2025

@rmbh-odoo @VincentSchippefilt cherrypicking of pull request #7400 failed.

stdout:

Auto-merging src/components/composer/composer/composer.ts
CONFLICT (content): Merge conflict in src/components/composer/composer/composer.ts
CONFLICT (modify/delete): src/plugins/ui_stateful/edition.ts deleted in d1efb0b98f7c9e1183da3f2fb6df592ea52c64fe and modified in 2c38d58bc57d5a0680bb0e92ab120cf86ab825c2.  Version 2c38d58bc57d5a0680bb0e92ab120cf86ab825c2 of src/plugins/ui_stateful/edition.ts left in tree.
Auto-merging tests/composer/autocomplete_dropdown_component.test.ts
CONFLICT (content): Merge conflict in tests/composer/autocomplete_dropdown_component.test.ts
CONFLICT (modify/delete): tests/composer/edition_plugin.test.ts deleted in d1efb0b98f7c9e1183da3f2fb6df592ea52c64fe and modified in 2c38d58bc57d5a0680bb0e92ab120cf86ab825c2.  Version 2c38d58bc57d5a0680bb0e92ab120cf86ab825c2 of tests/composer/edition_plugin.test.ts left in tree.

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

… changes

Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
  behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.

After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.

Task: 5226615
X-original-commit: 60a66b6
@rmbh-odoo rmbh-odoo force-pushed the 18.0-17.0-fix-composer-range-selection-rmbh-474879-fw branch from 2b68544 to 4eeb3a5 Compare November 18, 2025 13:19
@rmbh-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 19, 2025
… changes

Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
  behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.

After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.

closes #7475

Task: 5226615
X-original-commit: 60a66b6
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Signed-off-by: Ronakkumar Mukeshbhai Bharadiya (rmbh) <rmbh@odoo.com>
@robodoo robodoo closed this Nov 19, 2025
@rrahir
Copy link
Collaborator

rrahir commented Nov 24, 2025

hi, this forward port (and all following versions) have broken the composer. A quick example, open the topbar composer in which you have a formula (I tested on A1 in my case) then hit Escape - the composer is no longer closed/ Could you look into it ASAP because we shipped the bug in the latest release

@rmbh-odoo
Copy link
Contributor

hi, this forward port (and all following versions) have broken the composer. A quick example, open the topbar composer in which you have a formula (I tested on A1 in my case) then hit Escape - the composer is no longer closed/ Could you look into it ASAP because we shipped the bug in the latest release

Hello @rrahir 👋
This bug will be fixed in https://www.odoo.com/odoo/project/2328/tasks/5354541

@fw-bot fw-bot deleted the 18.0-17.0-fix-composer-range-selection-rmbh-474879-fw branch November 26, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants