[IMP] CF: add new conditional formats for dates #7490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component `DateCriterion` would trigger an `updateCriterion` call on startup if `criterion.dateValue` wasn't set. It's acceptable for data validations (it only triggers another render), but not acceptable for conditional formatting, where each call to `updateCriterion` will trigger a dispatch and a new revision. The component is now modified to default to `exactDate` if `criterion.dateValue` isn't set. Task: 5343283
This commit adds the `dateIs/dateIsBefore/dateIsAfter` conditional formats, as well as the excel export for these. Note: The excel export doesn't use Excel's date conditional formats, because they don't have the same behaviour as ours. We'll use custom formulas instead. Example: today is 2025/11/19 - Our date is last month: 2025/10/19 -> 2025/11/18 - Excel's date is last month: 2025/10/01 -> 2025/10/30 Task: 5343283
Collaborator
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[IMP] CF: add new conditional formats for dates
This commit adds the
dateIs/dateIsBefore/dateIsAfterconditionalformats, as well as the excel export for these.
Note:
The excel export doesn't use Excel's date conditional formats, because
they don't have the same behaviour as ours. We'll use custom formulas
instead.
Example: today is 2025/11/19
Task: 5343283
review checklist