Skip to content

[FIX] cf: conditional formatting preview is truncated for nothing #7492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[FIX] cf: conditional formatting preview is truncated for nothing #7492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/components/side_panel/conditional_formatting/cf_preview_list/cf_preview_list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,10 @@ css/* scss */ `
}
.o-cf-preview-icon {
border: 1px solid lightgrey;
position: absolute;
height: 50px;
width: 50px;
}
.o-cf-preview-description {
left: 65px;
margin-bottom: auto;
margin-right: 8px;
margin-top: auto;
position: relative;
width: 142px;
.o-cf-preview-description-rule {
margin-bottom: 4px;
font-weight: 600;
Expand All @@ -58,16 +51,11 @@ css/* scss */ `
font-size: 12px;
}
}
.o-cf-delete {
left: 90%;
top: 39%;
position: absolute;
}
&:not(:hover):not(.o-cf-dragging) .o-cf-drag-handle {
display: none !important;
}
.o-cf-drag-handle {
left: -8px;
left: 2px;
cursor: move;
.o-icon {
width: 6px;
Expand Down
60 changes: 29 additions & 31 deletions src/components/side_panel/conditional_formatting/cf_preview_list/cf_preview_list.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,46 +14,44 @@

<t t-name="o-spreadsheet-ConditionalFormattingPanelPreview">
<div
class="o-cf-preview d-flex position-relative"
class="o-cf-preview d-flex position-relative align-items-center"
t-att-class="{ 'o-cf-dragging': dragAndDrop.draggedItemId === cf.id }"
t-att-style="getPreviewDivStyle(cf)"
t-att-data-id="cf.id"
t-on-click="(ev) => props.onPreviewClick(cf)"
t-on-mousedown="(ev) => this.onMouseDown(cf, ev)">
<div class="position-relative h-100 w-100 d-flex align-items-center">
<div class="o-cf-drag-handle h-100 position-absolute d-flex align-items-center text-muted">
<t t-call="o-spreadsheet-Icon.THIN_DRAG_HANDLE"/>
<div class="o-cf-drag-handle h-100 position-absolute d-flex align-items-center text-muted">
<t t-call="o-spreadsheet-Icon.THIN_DRAG_HANDLE"/>
</div>
<t t-if="cf.rule.type==='IconSetRule'">
<div class="o-cf-preview-icon d-flex justify-content-around align-items-center me-3">
<t t-call="o-spreadsheet-Icon.{{icons[cf.rule.icons.upper].template}}"/>
<t t-call="o-spreadsheet-Icon.{{icons[cf.rule.icons.middle].template}}"/>
<t t-call="o-spreadsheet-Icon.{{icons[cf.rule.icons.lower].template}}"/>
</div>
<t t-if="cf.rule.type==='IconSetRule'">
<div class="o-cf-preview-icon d-flex justify-content-around align-items-center me-2">
<t t-call="o-spreadsheet-Icon.{{icons[cf.rule.icons.upper].template}}"/>
<t t-call="o-spreadsheet-Icon.{{icons[cf.rule.icons.middle].template}}"/>
<t t-call="o-spreadsheet-Icon.{{icons[cf.rule.icons.lower].template}}"/>
</div>
</t>
<t t-else="">
<div
t-att-style="getPreviewImageStyle(cf.rule)"
class="o-cf-preview-icon d-flex justify-content-around align-items-center me-2">
123
</div>
</t>
<div class="o-cf-preview-description">
<div class="o-cf-preview-ruletype">
<div class="o-cf-preview-description-rule text-truncate">
<t t-esc="getDescription(cf)"/>
</div>
</div>
<div class="o-cf-preview-range text-truncate" t-esc="cf.ranges"/>
</t>
<t t-else="">
<div
t-att-style="getPreviewImageStyle(cf.rule)"
class="o-cf-preview-icon d-flex justify-content-around align-items-center me-3 flex-shrink-0">
123
</div>
<div class="o-cf-delete">
<div
class="o-cf-delete-button text-muted"
t-on-click.stop="(ev) => this.deleteConditionalFormat(cf, ev)"
title="Remove rule">
<t t-call="o-spreadsheet-Icon.TRASH"/>
</t>
<div class="o-cf-preview-description me-3 overflow-auto">
<div class="o-cf-preview-ruletype">
<div class="o-cf-preview-description-rule text-truncate">
<t t-esc="getDescription(cf)"/>
</div>
</div>
<div class="o-cf-preview-range text-truncate" t-esc="cf.ranges"/>
</div>
<div class="o-cf-delete ms-auto">
<div
class="o-cf-delete-button text-muted"
t-on-click.stop="(ev) => this.deleteConditionalFormat(cf, ev)"
title="Remove rule">
<t t-call="o-spreadsheet-Icon.TRASH"/>
</div>
</div>
</div>
</t>
Expand Down
Loading